Add membrane tutorial with packmol-memgen setup#310
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
hannahbaumann
changed the title
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
[nit] It's ok as is, but also for a less technically minded audience, it would also be ok to just use ! to call the command line dirrectly.
Reply via ReviewNB
There was a problem hiding this comment.
Changed this!
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
[nit] can you put this in one of those warning boxes? Like we do for https://github.com/OpenFreeEnergy/ExampleNotebooks/blob/main/membranes/rbfe_membrane_protein.ipynb
Reply via ReviewNB
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #61. with open('a2a/complex_equ.pdb', 'w') as f:
[nit] might be good to call it "complex_equil", might just be me but "equ" is hard to parse somehow.
Reply via ReviewNB
There was a problem hiding this comment.
Renamed this!
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
To reduce maintenance burdens, it would be ok if the notebook finished here and just referred to another one.
Reply via ReviewNB
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Overall lgtm, a few nits, but nothing I would consider block.
| @@ -0,0 +1,833 @@ | |||
| { | |||
There was a problem hiding this comment.
Should this one be in the highlighted note box as well, it feels like an important one to highlight.
Reply via ReviewNB
3 participants
No description provided.