Support Certum-backed Windows release signing - #79
Merged
Conversation
|
👀 Human Input Needed → Pair Review Briefing |
| assert "OPENHCS_WINDOWS_SIGNING_CERTIFICATE_THUMBPRINT" in source | ||
| assert "OPENHCS_WINDOWS_SIGNING_CERTIFICATE_BASE64" not in source | ||
| assert "OPENHCS_WINDOWS_SIGNING_CERTIFICATE_PASSWORD" not in source | ||
| assert "Normalize-CertificateThumbprint" in source |
There was a problem hiding this comment.
The new Windows signing path is covered here only by source-text checks, so regressions in Normalize-CertificateThumbprint, env fallback, or certificate validation behavior would still pass as long as these tokens remain in the file. That leaves the non-trivial fail-closed signing gate without a behavioral test.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
OpenHCS production tags now use the same protected-key model as Fiji and Jaunch: a Certum Open Source Code Signing certificate projected into the current Windows user certificate store by SimplySign or compatible hardware/cloud middleware.
Trust boundary
Verification
Native acceptance still required
A signed release candidate requires the real Certum certificate/session, an interactive Windows signing runner, and the public OPENHCS_WINDOWS_SIGNING_CERTIFICATE_THUMBPRINT repository variable. No public installer is claimed to be signed by this PR alone.