Overhaul game settings with Kenyoni AppSettings integration#697
Merged
Conversation
Member
Author
|
Should fix the |
Spartan322
force-pushed
the
overhaul/settings
branch
15 times, most recently
from
395cfde to
9082554
Compare
Implement startup music disable option Replace GameSettings with Kenyoni AppSettings plugin Remove the C++ GameSettings resource and registration Add Godot-side Settings Autoload Globals: - GameSettings - ModSettings - Vic2Settings Add mods load list to setting GUI Add Victoria 2 base defines path to setting GUI Refactor callers (GameStart, MusicManager, MapView, OptionsMenu, MainMenu) to use the new API Add SettingsContainer UI to generate options dynamically Update project.godot to register autoloads and enable the plugin Update COPYRIGHT to attribute the new plugin files
Spartan322
force-pushed
the
overhaul/settings
branch
from
9082554 to
878881e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement startup music disable option
Replace GameSettings with Kenyoni AppSettings plugin
Remove the C++ GameSettings resource and registration
Add Godot-side Settings Autoload Globals:
Add mods load list to setting GUI
Add Victoria 2 base defines path to setting GUI
Refactor callers (GameStart, MusicManager, MapView, OptionsMenu, MainMenu) to use the new API
Add SettingsContainer UI to generate options dynamically
Update project.godot to register autoloads and enable the plugin
Update COPYRIGHT to attribute the new plugin files