fix: add context-aware diagnostics for class-string<static>#286
Merged
Conversation
Resolve self/static/$this/parent in parameter types to concrete class names before the type compatibility check, so that class-string<static> is properly validated instead of blanket- suppressed. The call-site context class is extracted from the call expression: ClassName::method uses the named class, static::/self::/$this-> uses the enclosing class, and parent:: uses its parent. This turns class-string<static> into class-string<DeclaringClass>, letting the existing class-string covariance check flag provably invalid arguments (unrelated classes) while still accepting child classes and siblings. Closes #273
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve self/static/$this/parent in parameter types to concrete class names before the type compatibility check, so that class-string is properly validated instead of blanket- suppressed.
The call-site context class is extracted from the call expression: ClassName::method uses the named class, static::/self::/$this-> uses the enclosing class, and parent:: uses its parent. This turns class-string into class-string, letting the existing class-string covariance check flag provably invalid arguments (unrelated classes) while still accepting child classes and siblings.
Closes #273
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.