Skip to content

Add Light Radius to weighted trade stats #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZenJediMind wants to merge 1 commit into
base: dev
Choose a base branch
from
+22 −0
Open

Add Light Radius to weighted trade stats #10024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions spec/System/TestTradeQueryGenerator_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,26 @@ describe("TradeQueryGenerator", function()

assert.are.equal(result, 1.2)
end)

it("supports light radius as a player stat weight", function()
local lightRadiusStat
local minionLightRadiusStat
for _, stat in ipairs(data.powerStatList) do
if stat.stat == "LightRadiusMod" then
lightRadiusStat = stat
elseif stat.stat == "MinionLightRadiusMod" then
minionLightRadiusStat = stat
end
end

assert.is_not_nil(lightRadiusStat)
assert.is_nil(minionLightRadiusStat)
local result = mock_queryGen.WeightedRatioOutputs(
{ LightRadiusMod = 1 },
{ LightRadiusMod = 1.25 },
{ { stat = lightRadiusStat.stat, weightMult = 1 } })
assert.are.equal(result, 1.25)
end)
end)

describe("Filter prioritization", function()
Expand Down
2 changes: 2 additions & 0 deletions src/Modules/Data.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ data.powerStatList = {
{ stat="IgniteChance", label="Ignite Chance" },
{ stat="ShockChance", label="Shock Chance" },
{ stat="EffectiveMovementSpeedMod", label="Move speed" },
{ stat="LightRadiusMod", label="Light Radius" },
{ stat="BlockChance", label="Block Chance" },
{ stat="SpellBlockChance", label="Spell Block Chance" },
{ stat="SpellSuppressionChance", label="Spell Suppression Chance" },
Expand Down Expand Up @@ -212,6 +213,7 @@ local minionNonApplicableStats = {
Int = true,
Spirit = true,
EffectiveLootRarityMod = true,
LightRadiusMod = true,
}
for i = 1, #data.powerStatList do
local statEntry = data.powerStatList[i]
Expand Down