Connected to frontend with e2e testing on create member and sign up form - #60
Connected to frontend with e2e testing on create member and sign up form#60Allimonae wants to merge 1 commit into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c3deb0a to
d3b485e
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/24/26)2 reviewers were added to this PR based on Henry Chen's automation. |
There was a problem hiding this comment.
nit - should probably be MemberNotFoundException for consistency. it will ultimately end up being a 404 anyway
There was a problem hiding this comment.
(i know this isnt part of the PR but might as well fix it here 🙃
| // TODO: Implement test cases for MemberService methods after createMember | ||
|
|
||
| // @Test | ||
| // void testUpdateMember() { |
There was a problem hiding this comment.
i guess we'll be adding these in another PR? is updateMember not fully functional yet?
There was a problem hiding this comment.
yea for this PR only createMember is fully functional and connected to the frontend. i will implement the other functions fully later on
d3b485e to
447a9d9
Compare
447a9d9 to
81f1c34
Compare
|
2 participants
Summary
matchingPreftomatchPrefacross the frontend/api/membersendpointWhat changed?
matchingPreftomatchPrefin theMemberProfileValuesinterface, Zod schema, and all related form field bindings and handlers inSignUpForm.tsx.matchingPrefOptionsvariable tomatchingPreferenceOptionsfor clarity.Promise.resolve()stub inSignUpForm's submit handler with a realPOST /api/membersfetch call. On success, the form is reset; on failure, an error message from the API response (or a fallback) is displayed; on network error, a connection-specific message is shown.MemberControllerTestcovering successful member creation, validation rejection on blankfullName, and conflict response on duplicate email.MemberServiceTestcovering successful member creation with all fields and duplicate email detection (verifyingcreateMemberon the repo is never called in that case).How to test?
/api/members, resets on success, and displays appropriate error messages on failure or network issues.MemberControllerTestandMemberServiceTestand confirm all tests pass.Why make this change?
The
matchingPreffield name was inconsistent with the backend'smatchPrefnaming convention, causing a mismatch between the frontend payload and the API contract. The form also lacked a real API integration, relying on a placeholder stub that never actually persisted data. Tests were added to establish baseline coverage for the member creation flow.