Fixed user profile page error#2618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } else { | ||
| dispUserSince = dateFormatter.format(accessedUserProfile.user_since); | ||
| dispUserSince = dateFormatter.format( | ||
| new Date(parseInt(accessedUserProfile.user_since) * 1000), |
There was a problem hiding this comment.
question, blocking: Why multiply by 1000?
There was a problem hiding this comment.
Without multiplying by 1000, the date kept showing up as January 1st, 1970. This happened because accessedUserProfile.user_since is a Unix timestamp in seconds, but JavaScript’s Date expects timestamps in milliseconds. So we multiply by 1000 to format the date correctly.
There was a problem hiding this comment.
question, blocking: But when using this code with working profiles, I'm able to properly display the date without multiplying by 1000
When we actually write the record to the table, I believe we use JS Date, not something native to the database, for this exact purpose.
|
|
||
| const POLICYENGINE_API = "https://api.policyengine.org"; | ||
| const POLICYENGINE_API = | ||
| process.env.REACT_APP_API_URL || "https://api.policyengine.org"; |
There was a problem hiding this comment.
question: Why add this environment variable?
There was a problem hiding this comment.
I added REACT_APP_API_URL for local development and testing. I wasn’t able to get the frontend and backend to connect properly without it. It defaults to the live API if not set, so production behavior isn’t affected. I left it in since it might be helpful for others running things locally, but I can remove it if it’s not needed.
|
Thank you for this contribution. Closing as part of the If this is still relevant, please consider re-opening it against |
3 participants
Description
Fixes #2589
Changes