Change to release env for syncing examples#73
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
left a comment
There was a problem hiding this comment.
We don't do releases, do we need this change?
Also,
To confirm if the release bot is set up to have only current repo level access and not access to org level repos.
Have you checked this box yet?
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
left a comment
There was a problem hiding this comment.
if we only are allowed to sync on main (which makes sense), can we please add a CI check that none of the files in PGM main are edited directly in this repo?
|
As an extra check then? Since I removed token in 7155201, editing is not possible. (And later writing needs release token)
|
yes, if someone provides a new workshop contribution, and they edit files they should not be editing (as they will be overwritten on |
Because only the release environment contains write permissions now.
This is now an unblocking question since I added But nice to know about its scope regardless. @TonyXiang8787 Does the release token give access to current repository or to all repositories of PowerGridModel? |
|
@nitbharambe the secret itself (private key and id) gives release access to all PGM repo's. The generated token, I don't know. |
|
@nitbharambe is this ready to merge? |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
Ready to merge |
I see refresh lock and linter dependencies is missing and needed. Ill add it separately