Skip to content

Change to release env for syncing examples#73

Merged
mgovers merged 3 commits into
mainfrom
pgm/sync-examples-release-env
Jul 2, 2026
Merged

Change to release env for syncing examples#73
mgovers merged 3 commits into
mainfrom
pgm/sync-examples-release-env

Conversation

@nitbharambe

@nitbharambe nitbharambe commented Jun 26, 2026

Copy link
Copy Markdown
Member
  • To confirm if the release bot is set up to have only current repo level access and not access to org level repos.

I see refresh lock and linter dependencies is missing and needed. Ill add it separately

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review June 29, 2026 09:38

@figueroa1395 figueroa1395 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do releases, do we need this change?

Also,

To confirm if the release bot is set up to have only current repo level access and not access to org level repos.

Have you checked this box yet?

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>

@mgovers mgovers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we only are allowed to sync on main (which makes sense), can we please add a CI check that none of the files in PGM main are edited directly in this repo?

@nitbharambe

Copy link
Copy Markdown
Member Author

As an extra check then? Since I removed token in 7155201, editing is not possible. (And later writing needs release token)

if we only are allowed to sync on main (which makes sense), can we please add a CI check that none of the files in PGM main are edited directly in this repo?

@mgovers

mgovers commented Jun 30, 2026

Copy link
Copy Markdown
Member

As an extra check then?

yes, if someone provides a new workshop contribution, and they edit files they should not be editing (as they will be overwritten on main when the syncer runs), there should be a CI check telling them that

@nitbharambe

Copy link
Copy Markdown
Member Author

We don't do releases, do we need this change?

Because only the release environment contains write permissions now.

Have you checked this box yet?

This is now an unblocking question since I added repositories: power-grid-model-workshop to scope the token for sync-examples.

But nice to know about its scope regardless. @TonyXiang8787 Does the release token give access to current repository or to all repositories of PowerGridModel?

@TonyXiang8787

Copy link
Copy Markdown
Member

@nitbharambe the secret itself (private key and id) gives release access to all PGM repo's. The generated token, I don't know.

@TonyXiang8787

Copy link
Copy Markdown
Member

@nitbharambe is this ready to merge?

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe

Copy link
Copy Markdown
Member Author

Ready to merge

@mgovers mgovers merged commit 68d26f4 into main Jul 2, 2026
2 checks passed
@mgovers mgovers deleted the pgm/sync-examples-release-env branch July 2, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants