feat(dataview): read data rows truely on demand#1717
Open
Fred-Wu wants to merge 2 commits into
Open
Conversation
- Keep the original R data source and slice only requested rows instead of preparing complete columns when the viewer opens. - Avoid full Arrow conversion, support Polars DataFrames, preserve R value types, and reuse sorting and filtering results when the viewer requests more rows.
…ta types - use dateString and dateTimeString for R Date and POSIX values - use bigint for R integer64 values - make bit64 an optional package dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to introduce a true on demand data loading from R.
The RC already introduced a dynamic data viewer, but R still prepared data for all columns when the viewer opened. This included creating the full row index, splitting matrix columns, and converting an entire Arrow object data to data frame. Values were also formatted as text.
What changes
On-demand loading
Data Viewer Changes
(filtered/original)in the row-number heading when filtering is active.If this is accepted, and works well, probably could remove those 2 pagination settings as well. Here is an example to open 10M records with 100 columns.
demo.mov