align skill helper script paths with scripts/ convention (#143)#144
Open
operetz-rh wants to merge 1 commit into
Open
align skill helper script paths with scripts/ convention (#143)#144operetz-rh wants to merge 1 commit into
operetz-rh wants to merge 1 commit into
Conversation
Collaborator
|
@r2dedios pls take a look, thank you! |
r2dedios
requested changes
Jul 24, 2026
| ## Step 6: After Retrieval | ||
|
|
||
| - **Parse response**: Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | ||
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | |
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md). |
../references folder in that relative link it's incorrect. There is another folder called flows before
| ## Step 6: After Retrieval | ||
|
|
||
| - **Parse response**: Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | ||
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | |
| - **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md). |
| ## Step 4: After Listing | ||
|
|
||
| - **Parse response** (if needed): Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | ||
| - **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). |
Contributor
There was a problem hiding this comment.
Suggested change
| - **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md). | |
| - **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md). |
| ```bash | ||
| # Step 1: Setup — applies RBAC to each cluster, extracts SA tokens | ||
| python3 ocp-admin/scripts/cluster-report/build-kubeconfig.py setup --all-contexts | ||
| python3 scripts/build-kubeconfig.py setup --all-contexts |
Contributor
There was a problem hiding this comment.
I identify two issues:
- the
build-kubeconfig.pyfile doesn't exist in thescriptsdirectory, so it will fail - I'm missing the
SCRIPTS_DIRvalidation like in the rest of the skills
SCRIPTS_DIR="scripts"
test -f "$SCRIPTS_DIR/validate_input.py" || { echo "Error: Scripts directory not found at $SCRIPTS_DIR"; exit 1; }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pack(s) affected
ocp-adminrh-ai-engineerrh-automationrh-basicrh-developerrh-srerh-virtChange type
mcps.json)Contribution method
/agentic-contribution-skillmake validate+make validate-skill-design-changed)Pack-persona alignment (new skills only)
AGENTS.md compliance
${VAR}referencesValidation
make validatepasses locallyname,description)name,description)