Skip to content

align skill helper script paths with scripts/ convention (#143)#144

Open
operetz-rh wants to merge 1 commit into
mainfrom
fix/issue-143-skill-script-paths
Open

align skill helper script paths with scripts/ convention (#143)#144
operetz-rh wants to merge 1 commit into
mainfrom
fix/issue-143-skill-script-paths

Conversation

@operetz-rh

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

AGENTS.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@operetz-rh
operetz-rh marked this pull request as ready for review July 21, 2026 12:31
@dmartinol

Copy link
Copy Markdown
Collaborator

@r2dedios pls take a look, thank you!

## Step 6: After Retrieval

- **Parse response**: Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py) with `FILTER_REMEDIATABLE=1`. Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md).

../references folder in that relative link it's incorrect. There is another folder called flows before

## Step 6: After Retrieval

- **Parse response**: Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response**: Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md).

## Step 4: After Listing

- **Parse response** (if needed): Use [references/01-cve-response-parser.py](../references/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../references/02-cve-parsing-guide.md).
- **Parse response** (if needed): Use [scripts/01-cve-response-parser.py](../../scripts/01-cve-response-parser.py). Do NOT use jq or inline Python. See [02-cve-parsing-guide.md](../02-cve-parsing-guide.md).

```bash
# Step 1: Setup — applies RBAC to each cluster, extracts SA tokens
python3 ocp-admin/scripts/cluster-report/build-kubeconfig.py setup --all-contexts
python3 scripts/build-kubeconfig.py setup --all-contexts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I identify two issues:

  1. the build-kubeconfig.py file doesn't exist in the scripts directory, so it will fail
  2. I'm missing the SCRIPTS_DIR validation like in the rest of the skills
SCRIPTS_DIR="scripts"
test -f "$SCRIPTS_DIR/validate_input.py" || { echo "Error: Scripts directory not found at $SCRIPTS_DIR"; exit 1; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants