Skip to content

Add support for retrieving raw file content from GitLab#124

Open
gavanderhoorn wants to merge 4 commits into
RoboStack:masterfrom
gavanderhoorn:add_gitlab_raw_support
Open

Add support for retrieving raw file content from GitLab#124
gavanderhoorn wants to merge 4 commits into
RoboStack:masterfrom
gavanderhoorn:add_gitlab_raw_support

Conversation

@gavanderhoorn

@gavanderhoorn gavanderhoorn commented Jul 3, 2026

Copy link
Copy Markdown

As per title.

I had a couple packages which were hosted on gitlab.com but were not released / did not have a release repository on github.com.

Adding them to rosdistro_additional_recipes.yaml works fine, but when Vinca tried to download their manifests it ran into this line and refused.

GitLab raw URLs are relatively simple, and c6092b4 adds a formatter for them. Follow-up commits then use it when needed.

Checking for host substrings in URLs is a bit brittle, but I did not want to diverge from the existing pattern too much.

The GitHub download path should not be affected by the refactor, it's mostly just shuffling existing code around.

Refactor GitHub formatting code and add GitLab formatter.
Return either cached version or attempt download and return result.
@gavanderhoorn

Copy link
Copy Markdown
Author

I'm also wondering how to support packages not on github.com or gitlab.com, but on self-hosted GitLab instances fi.

The latter could use _construct_raw_url_gitlab(..), but without a domain to match against I'm not sure how Vinca would detect which variant of the formatter it should use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants