Feature/spoolman card uid#6
Open
Rocka84 wants to merge 3 commits into
Open
Conversation
8 tasks
c28f09b to
8eeda96
Compare
Adds client-side pagination to fetchSpoolmanByExternalId to support Spoolman instances without PR #904. Also adds a note to AGENTS.md.
8eeda96 to
44031cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completely migrates tag lookup and spool association from relying on legacy fields like
lot_nrorSPOOL_IDto utilizing the physical NFC Tag UID (hardware_uidmapped toCARD_UID). This provides a much cleaner, robust, and native way to track physical spools.It introduces the following major changes:
CARD_UIDdirectly to thefilament_detect/setwebhook for the SpoolLink agent during spool loading.card_uidof that spool is automatically loaded and transmitted to the printer.hardware_uidwith that spool in Spoolman (appending it toextra.card_uids).spool_id. It also supports comma-separated values for multiple tags per spool and auto-appends to the list if migration is needed.extrafields (i.e., vanilla Spoolman without PR #904), the ESP32 will automatically fetch spools in chunks and resolve the UID locally, ensuring full compatibility without requiring users to run custom forks.lot_nridentifiers for proprietary Bambu Lab and Snapmaker tags have been completely removed. These tags now natively match via their physicalhardware_uidor via the legacylot_nrfallback if they were saved in the old format.Card UIDfield to the extended info view so users can easily read the hardware UID.This PR cannot be merged yet, as it relies on an unmerged upstream feature. It is currently waiting for SnapmakerU1-Extended-Firmware PR #491 which introduces the SpoolLink agent and changes the spool mapping format to use
CARD_UID.Note on Spoolman: We no longer block on Spoolman PR #904 because we implemented a local pagination fallback for vanilla Spoolman instances. Once PR #904 is merged, the fallback code may be removed.