ENH: Resolve pressure_ISA discretization bounds TODO#1056
Open
Gui-FernandesBR wants to merge 1 commit into
Open
ENH: Resolve pressure_ISA discretization bounds TODO#1056Gui-FernandesBR wants to merge 1 commit into
Gui-FernandesBR wants to merge 1 commit into
Conversation
Gui-FernandesBR
commented
Jul 9, 2026
Comment on lines
2555
to
+2558
| # Discretize this Function to speed up the trajectory simulation | ||
| altitudes = np.linspace(0, 80000, 100) # TODO: should be -2k instead of 0 | ||
| min_height = geopotential_height_to_geometric_height(-2000, earth_radius) | ||
| max_height = geopotential_height_to_geometric_height(80000, earth_radius) | ||
| altitudes = np.linspace(min_height, max_height, 100) |
Member
Author
There was a problem hiding this comment.
I am not sure... It seems the behavior is changing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR resolves a TODO comment in
ocketpy/environment/environment.py\ that suggested discretizing the Standard Atmosphere model (\pressure_ISA) starting from -2000 m (the lower bound of the geopotential layers) instead of 0 m.
Checklist
ocketpy/environment/environment.py\ from \