Skip to content

BUG: Environment not Encoding Necessary Parameters for Decode#1059

Merged
Gui-FernandesBR merged 1 commit into
developfrom
bug/environment-decode
Jul 9, 2026
Merged

BUG: Environment not Encoding Necessary Parameters for Decode#1059
Gui-FernandesBR merged 1 commit into
developfrom
bug/environment-decode

Conversation

@phmbressan

@phmbressan phmbressan commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (make format) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The Environment did not encode some necessary parameters for a few file types. This caused an error on decode.

New behavior

The parameters were added to the to_dict and a test was created to validate it.

Breaking change

  • Yes
  • No

@phmbressan phmbressan requested a review from a team as a code owner July 9, 2026 21:22
@phmbressan phmbressan changed the title BUG: environment to_dict lacks parameters. BUG: Environment not Encoding Necessary Parameters for Decode Jul 9, 2026
@phmbressan phmbressan self-assigned this Jul 9, 2026
@phmbressan phmbressan added the Bug Something isn't working label Jul 9, 2026
@phmbressan phmbressan added this to the Release v1.X.0 milestone Jul 9, 2026
@phmbressan phmbressan force-pushed the bug/environment-decode branch from 0d42095 to 01ee676 Compare July 9, 2026 21:28
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.84%. Comparing base (4a67a41) to head (7cae251).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/tools.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1059      +/-   ##
===========================================
+ Coverage    81.74%   81.84%   +0.10%     
===========================================
  Files          118      118              
  Lines        15248    15254       +6     
===========================================
+ Hits         12464    12485      +21     
+ Misses        2784     2769      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop July 9, 2026 22:20
@Gui-FernandesBR Gui-FernandesBR force-pushed the bug/environment-decode branch from 01ee676 to 7cae251 Compare July 9, 2026 22:20
@Gui-FernandesBR Gui-FernandesBR merged commit 490a293 into develop Jul 9, 2026
7 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/environment-decode branch July 9, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants