CI/CD Deps update#2590
Merged
Merged
Conversation
The dependency cache key hashed python_requirements.txt, but that file only affects the pip/conda environment, not the compiled C++ dependency tree in $HOME/install produced by build_dependencies.sh (which never reads it). Dependabot bumps to python_requirements.txt (e.g. #2578, #2579) therefore rotated the key on nearly every batch of PRs, forcing a full ~1.5-2h rebuild of VTK/ITK/Qt/OpenVDB and causing each PR to save its own duplicate copy of the deps cache. Removing it from the key lets pip version bumps reuse the existing dependency cache. Deliberately not adding restore-keys: a prefix fallback would restore a stale $HOME/install that gha_deps.sh would then treat as valid (it skips its rebuild whenever that directory exists), linking against dependencies that no longer match build_dependencies.sh. Refs #2589.
Persist ccache using GHA cache Add actions/cache restore+save around the build step (Linux release/debug, macOS intel/arm64; Windows stays off). Per-commit key with a restore-keys prefix fallback (safe for ccache, which re-validates each object). Save uses if: always() + continue-on-error to survive test failures and re-runs. Refs #2589.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop python_requirements.txt from dependency cache key
Persist ccache across runs for Linux and macOS builds