Handle contour polylines with >2-point line cells (#2377)#2593
Merged
Conversation
VTK can store a contour as a single polyline cell with more than two points. ShapeWorks assumed line cells always have exactly two points, so such a contour was misdetected as a mesh (the contour-detection check required GetCell(0) to have two points) and crashed in optimization. - OptimizeParameters: detect a contour by cell type (VTK_LINE or VTK_POLY_LINE) instead of point count, so polylines are routed to the contour path. - ContourDomain::SetPolyLine: split any polyline cell into two-point segments before building the contour, so the rest of the contour code (which assumes two-point line cells) works. Adds OptimizeTests.contour_polyline_test with a fixture of polyline contours; without the fix the polyline is processed as a mesh and the optimization crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2377
VTK can store a contour as a single polyline cell with more than two points. ShapeWorks assumed line cells always have exactly two points, so such a contour was misdetected as a mesh (the contour-detection check required GetCell(0) to have two points) and crashed in optimization.
Adds OptimizeTests.contour_polyline_test with a fixture of polyline contours; without the fix the polyline is processed as a mesh and the optimization crashes.