Report an error for corrupt mesh files instead of crashing (#2048)#2597
Merged
Conversation
VTK file readers do not throw or set an error code on a malformed file; they emit an error event and hand back partial/garbage data, which downstream filters (e.g. vtkCleanPolyData) could then read out of bounds and crash. Attach an error observer to each reader in MeshReader::read and throw when it fires, so a corrupt file surfaces as a clean read error rather than a crash or silently-loaded garbage. Add a MeshTests case covering a malformed .vtk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2048
A malformed mesh file (e.g. the attached
corrupt.vtk, whosePOLYGONSsize count doesn't match the connectivity that follows) crashed Studio. The original stack trace showed the crash invtkCleanPolyDatareading points out of bounds.