Fix optimizer hack to detect contour types (#2457)#2598
Merged
Conversation
Contour-vs-mesh detection inspected the first cell's point count (or type), which misclassifies a surface mesh whose first cell happens to be a line and was duplicated as a fragile hack across the codebase. Add MeshUtils::is_contour, which classifies by cell content — a contour has only line cells, a mesh has polygon/strip cells — and use it in the optimizer, the groom remesh guard and integrity check, and the mesh warper. Add a MeshTests case covering the mixed-cell mesh the old first-cell check missed.
akenmorris
force-pushed
the
amorris/2457-contour-detection
branch
from
July 17, 2026 06:26
b35b927 to
112ab93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2457
Add
MeshUtils::is_contour(), which classifies by cell content rather than the first cell: a contour has only line cells, while a surface mesh has polygon or triangle-strip cells (matching theGetNumberOfPolys() == 0convention already used inrepair_mesh).