Add accounting diagnostic guides: invoice/timesheet locking + prepaid/receipt/recurring#9
Merged
Merged
Conversation
…ipt/recurring diagnostics Five new accounting guides driven by recurring real-world diagnostic patterns (scrubbed to Northwind placeholders): - invoice-timesheet-locked: locked invoice vs timesheet-locked-by-invoice vs sync - prepaid-reconciliation-delta: chase a non-zero prepaid delta - credit-note-prepaid-credit: why a credit note didn't reduce the prepaid balance - receipt-allocation: payment applied to the wrong invoice / split - recurring-invoice-gap: stalled/overdue recurring template Cross-link locked timesheets from the dev saved-timesheets-wrong guide so `tp dev guide` surfaces it too. All commands verified against the real tp surface; adds exact-match ranking tests for each new guide. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new set of accounting diagnostic “guide recipes” to the TimePro CLI guide system (plus a dev-guide cross-link), improving the discoverability of common finance investigations via tp accounting guide.
Changes:
- Added 5 new accounting diagnostic guides (locking, prepaid delta/crediting, receipt allocation, recurring invoice gaps) and registered them in the accounting guide index.
- Updated the dev “saved timesheets wrong” guide + keywords to route “locked timesheet” investigations to the accounting locking guide.
- Added guide-ranking tests to ensure these new use-cases resolve as exact matches.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SSW.TimePro.Cli.Tests/Features/Guides/GuideRankingTests.cs | Adds ranking coverage for the 5 new accounting guides. |
| guides/dev/saved-timesheets-wrong.md | Adds a cross-reference for “locked timesheet” scenarios to the accounting locking guide. |
| guides/dev/index.json | Adds new keywords so dev guide search can route “locked timesheet” queries appropriately. |
| guides/accounting/index.json | Registers the 5 new accounting guides (slugs, keywords, commands, MCP tools, skills). |
| guides/accounting/invoice-timesheet-locked.md | New guide: diagnose invoice lock vs timesheet-locked-by-invoice vs external sync. |
| guides/accounting/prepaid-reconciliation-delta.md | New guide: diagnose non-zero prepaid reconciliation deltas. |
| guides/accounting/credit-note-prepaid-credit.md | New guide: explain why a credit note doesn’t reduce prepaid balance. |
| guides/accounting/receipt-allocation.md | New guide: diagnose misallocated receipts across invoices. |
| guides/accounting/recurring-invoice-gap.md | New guide: diagnose stalled/overdue recurring invoice templates. |
…t, wording - receipt-allocation guide: populate mcpTools with the real accounting MCP tools (GetReceiptDetail, GetInvoiceReceipts, GetClientOutstanding). - GuideRankingTests: assert MatchType on the matched element (fold into ContainSingle) instead of indexing [0], so a tie can't validate the wrong guide. - saved-timesheets-wrong: 'invoice/lock problem' -> 'invoice lock problem'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- prepaid-reconciliation-delta + credit-note-prepaid-credit: add GetPrepaidStatus - recurring-invoice-gap: add ListRecurringInvoices, GetRecurringInvoice All verified to exist in AccountingMcpTools.cs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Five new
tp accounting guiderecipes for recurring real-world finance diagnostics, plus a dev cross-link. All examples use Northwind placeholders (no real client/personal data — enforced by the existing sanitization test).original − drawnDown − credited ≠ remaining)isCreditingInvoice+associatedInvoiceIdrule)Notes
tpsurface (tp invoice get/timesheets [--writeoff],tp receipt get/outstanding,tp prepaid summary,tp creditnote list,tp recurring list --outdated).saved-timesheets-wrongnow carrieslocked timesheetkeywords + a cross-ref, sotp dev guideroutes developers to the locking guide too.Draft for review. Sourced from mined diagnostic history.
🤖 Generated with Claude Code