implemented ConcernUsageExtensions and corresponding test#311
Closed
TanaseMariusatstarion wants to merge 6 commits into
Closed
implemented ConcernUsageExtensions and corresponding test#311TanaseMariusatstarion wants to merge 6 commits into
TanaseMariusatstarion wants to merge 6 commits into
Conversation
…geextensions' into 108-feature-implement-concernusageextensions # Conflicts: # SysML2.NET.Tests/Extend/ConcernUsageExtensionsTestFixture.cs # SysML2.NET/Extend/ConcernUsageExtensions.cs
|
antoineatstariongroup
requested changes
Jun 29, 2026
antoineatstariongroup
left a comment
antoineatstariongroup
left a comment
Collaborator
There was a problem hiding this comment.
General comment : It's preferable to rebase the branch to not have to review changes that are already part of the development branch
| .OfType<IFeatureTyping>() | ||
| .Select(featureTyping => featureTyping.Type) | ||
| .OfType<IConcernDefinition>() | ||
| .FirstOrDefault(); |
Collaborator
There was a problem hiding this comment.
The documentation specifies "the single type", I would recommend to use .SingleOrDefault() instead of .FirstOfDefault().
| return concernUsageSubject == null | ||
| ? throw new ArgumentNullException(nameof(concernUsageSubject)) | ||
| : concernUsageSubject.OwnedRelationship | ||
| .OfType<IFeatureTyping>() |
Collaborator
There was a problem hiding this comment.
It's preferable to use the ".type" property here
antoineatstariongroup
deleted the
108-feature-implement-concernusageextensions
branch
June 29, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixed #108 implementation of ConcernUsage extension.