Pin Foundations on top, brand per framework, add logo#67
Merged
Conversation
Fixes the sidebar order so Foundations always sorts above Components and stays alphabetically consistent between the React and Angular Storybooks (storySort has to be a literal per preview.ts — Storybook's index generator reads it via static AST analysis and never executes the shared config module). Also brands each Storybook's title with its framework name and adds the SURF logo, and links both deployed Storybooks from the README.
sjoerdbeentjes
changed the title
The logo was rendering at Storybook's brandImage cap (100px tall). Now it's a small icon with "Design System - <Framework>" text next to it, which requires leaving brandImage unset so Storybook renders brandTitle as raw HTML instead of plain text. Also trims some overly long comments and drops a stale commented-out code example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storySortinto a literal in eachpreview.ts— Storybook's index generator reads it via static AST analysis and never executes the shared@surfnet/storybook-configmodule, so a value reached through a spread was silently ignored.registerManager(framework).packages/storybook-config/src/logo.ts, inlined as an SVG data URI so it works identically under both the Vite and webpack manager builds) asbrandImage.Test plan
pnpm buildandpnpm lintpass