Skip to content

feat: add mise support and other goodies#1202

Open
hazre wants to merge 18 commits into
devfrom
hazre/feat/add-mise-support
Open

feat: add mise support and other goodies#1202
hazre wants to merge 18 commits into
devfrom
hazre/feat/add-mise-support

Conversation

@hazre

@hazre hazre commented Jul 22, 2026

Copy link
Copy Markdown
Member

Description

Adds mise tooling to the repo for easy installation of other tooling like node, pnpm, rust and etc. as well as a unified task runner for the project.

I also converted some of the bash scripts to js and added relevant mise metadata, so it its well integrated with mise.

Swapped fpm for nfpm so there is less dependencies and we can use a config file for linux packaging.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@hazre hazre added the internal label Jul 22, 2026
@hazre hazre self-assigned this Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

OpenTofu plan for production

Plan: 2 to add, 0 to change, 2 to destroy.
OpenTofu used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

OpenTofu will perform the following actions:

  # cloudflare_worker_version.site must be replaced
-/+ resource "cloudflare_worker_version" "site" {
!~      annotations         = {
+           workers_message      = (known after apply)
+           workers_tag          = (known after apply)
!~          workers_triggered_by = "create_version_api" -> (known after apply)
        } -> (known after apply)
!~      assets              = { # forces replacement
!~          asset_manifest_sha256 = "0d77329279e54c9584f2ea13c8f6f8c63fb7314c36297bd93964d3fe18b6d3d3" -> "ef3c345f92dfa8f3ec539c8309dbf4ea5724d2c00c5dabef208e89d9788b5bb9" # forces replacement
!~          directory             = "/home/runner/work/Sable/Sable/dist" -> "/github/workspace/dist"
#            (1 unchanged attribute hidden)
        }
+       compatibility_flags = (known after apply)
!~      created_on          = "2026-07-17T20:34:47Z" -> (known after apply)
!~      id                  = "************************************" -> (known after apply)
+       limits              = (known after apply)
+       main_script_base64  = (known after apply)
!~      number              = 1528 -> (known after apply)
!~      source              = "terraform" -> (known after apply)
+       startup_time_ms     = (known after apply)
#        (4 unchanged attributes hidden)
    }

  # cloudflare_workers_deployment.site must be replaced
-/+ resource "cloudflare_workers_deployment" "site" {
!~      annotations  = { # forces replacement
!~          workers_message      = "v1.20.0" -> "feat: add mise support and other goodies"
!~          workers_triggered_by = "deployment" -> (known after apply)
        }
!~      author_email = "cloudflare@sl.sable.moe" -> (known after apply)
!~      created_on   = "2026-07-17T20:34:47Z" -> (known after apply)
!~      id           = "************************************" -> (known after apply)
!~      source       = "terraform" -> (known after apply)
!~      versions     = [ # forces replacement
!~          {
!~              version_id = "************************************" -> (known after apply)
#                (1 unchanged attribute hidden)
            },
        ]
#        (3 unchanged attributes hidden)
    }

Plan: 2 to add, 0 to change, 2 to destroy.

Warning: Attribute Deprecated

  with cloudflare_workers_custom_domain.site,
  on main.tf line 41, in resource "cloudflare_workers_custom_domain" "site":
  41:   environment = "production"

This attribute is deprecated.

(and one more similar warning elsewhere)

📝 Plan generated in Cloudflare Infra #237

@hazre
hazre force-pushed the hazre/feat/add-mise-support branch 5 times, most recently from 9d242c7 to 8d6da33 Compare July 23, 2026 03:08
hazre added 17 commits July 23, 2026 05:20
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
- Add nfpm.yaml declarative config with contents, deps, per-packager overrides
- Replace fpm CLI invocations in package.sh with nfpm pkg
- Manage appimagetool and nfpm via mise file task tools
- Remove manual appimagetool download + sha256 verification
- Fix stale paths from scripts/cef/ move (ROOT, copy-libs reference, usage)
- Add version extraction guard and appimagetool availability check

Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
@hazre
hazre force-pushed the hazre/feat/add-mise-support branch from 8d6da33 to 3aafaa9 Compare July 23, 2026 03:20
@hazre

hazre commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

Okay I think it's in a pretty good state. I just need need some peeps to give it a go, ideally on different OS's and also double check CI, in case I missed anywhere that can be replaced with mise.

Also one big change was switch from fpm to nfpm. I need someone on linux to test mise run cef:package, it looks sane to me but nfpm config might need to be changed.

@hazre
hazre marked this pull request as ready for review July 23, 2026 03:22
@hazre
hazre requested a review from 7w1 as a code owner July 23, 2026 03:22
Signed-off-by: hazre <mail@haz.re>
@github-actions

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1202-sable.raspy-dream-bb1d.workers.dev 4fa1298 pr-1202 Thu, 23 Jul 2026 04:23:41 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants