Skip to content

fix: guard getAppPathFromHref against Tauri synthetic origin mismatch#1233

Merged
hazre merged 3 commits into
SableClient:devfrom
eleboucher:fix/page-no-found-after-login
Jul 23, 2026
Merged

fix: guard getAppPathFromHref against Tauri synthetic origin mismatch#1233
hazre merged 3 commits into
SableClient:devfrom
eleboucher:fix/page-no-found-after-login

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

fixes the page not found after login

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 23, 2026 06:35
@eleboucher
eleboucher force-pushed the fix/page-no-found-after-login branch from e5880c4 to 7f50044 Compare July 23, 2026 07:36
hazre
hazre requested changes Jul 23, 2026
View reviewed changes
Comment thread src/app/pages/pathUtils.ts Outdated
Comment thread src/client/initMatrix.ts Outdated
Comment thread src/app/pages/client/BackgroundNotifications.tsx Outdated
@hazre hazre added internal bug/behaviour behaviour bug labels Jul 23, 2026
@eleboucher
eleboucher force-pushed the fix/page-no-found-after-login branch from 7f50044 to 6f458cb Compare July 23, 2026 08:36
@eleboucher
eleboucher force-pushed the fix/page-no-found-after-login branch 2 times, most recently from fb6cfda to 1bf5697 Compare July 23, 2026 08:45
hazre
hazre approved these changes Jul 23, 2026
View reviewed changes

@hazre hazre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hazre
hazre added this pull request to the merge queue Jul 23, 2026
Merged via the queue into SableClient:dev with commit 95d64f3 Jul 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hazre hazre hazre approved these changes
@7w1 7w1 Awaiting requested review from 7w1 7w1 is a code owner

Assignees

No one assigned

Labels

bug/behaviour behaviour bug internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eleboucher @hazre