Skip to content

@W-23195592 surface custom step types in cartridge view#547

Merged
charithaT07 merged 4 commits into
developfrom
W-23195592-Surface-custom-step-types
Jul 6, 2026
Merged

@W-23195592 surface custom step types in cartridge view#547
charithaT07 merged 4 commits into
developfrom
W-23195592-Surface-custom-step-types

Conversation

@charithaT07

@charithaT07 charithaT07 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Brief description of what this PR does.

Surfaces Custom Step Types as a third category in the Cartridges explorer and adds Workspace Jobs discovery from jobs.xml, with filter UX polish for the Jobs view.

What changed

  • Custom Step Types tree — each cartridge now shows a "Step Types" group populated from steptypes.json. Click a step type to open its module .js; right-click → "Show Step Type Definition" jumps to the @type-id line in the JSON.
    Cross-cartridge module resolution supported.
  • Workspace Jobs section — Jobs tree now shows a "Workspace" section alongside run history, scanning **/jobs.xml in the workspace. A file-system watcher keeps it in sync. When the server reports a job as not runnable, the user is
    prompted to auto-deploy the definition from the workspace.
  • Filter UX — filter icon swaps between outlined/filled based on active-filter state. "Clear All Filters" now resets both status and advanced fields in one action. Active filter summary shown in the tree view message bar.

Testing

  • Unit tests added for collectStepTypeEntries (canonical, legacy flat-array, malformed JSON, missing fields) and resolveStepTypeModule (with/without .js, cross-cartridge, unresolvable ref).
  • jobs-menu.test.ts updated to assert new commands, filter icon swap, and workspace-job context menu entries.
  • Manually verified in Extension Development Host: step types appear under cartridges, click/right-click navigation works, filter icon toggles correctly.

Dependencies

  • No net-new third-party dependencies were added
  • If net-new third-party dependencies were added, rationale/discussion is included and 3pl-approved is set by a maintainer

  • Tests pass (pnpm test)
  • Code is formatted (pnpm run format)

@charithaT07 charithaT07 changed the title @W-23195592 Surface custom step types in cartridge view @W-23195592 surface custom step types in cartridge view Jul 2, 2026
@charithaT07 charithaT07 marked this pull request as ready for review July 6, 2026 18:10
@charithaT07 charithaT07 merged commit 0c095db into develop Jul 6, 2026
2 checks passed
@charithaT07 charithaT07 deleted the W-23195592-Surface-custom-step-types branch July 6, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants