Skip to content

Complete the porting of the main compute kernels#287

Merged
EmilyBourne merged 36 commits into
mainfrom
ebourne_gradual_gpu_port_part_4
Jun 15, 2026
Merged

Complete the porting of the main compute kernels#287
EmilyBourne merged 36 commits into
mainfrom
ebourne_gradual_gpu_port_part_4

Conversation

@EmilyBourne

Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@julianlitz

Copy link
Copy Markdown
Collaborator

Looking alright

@EmilyBourne EmilyBourne force-pushed the ebourne_gradual_gpu_port_part_4 branch from c03b237 to 912d554 Compare June 12, 2026 12:07
@EmilyBourne EmilyBourne changed the title WIP: More porting Complete the porting of the main compute kernels Jun 12, 2026
@EmilyBourne

Copy link
Copy Markdown
Collaborator Author

On v100 at a0e712b:
Without MUMPS:

100% tests passed, 0 tests failed out of 496

With MUMPS:

100% tests passed, 0 tests failed out of 500

@EmilyBourne EmilyBourne marked this pull request as ready for review June 12, 2026 15:32

@julianlitz julianlitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.17476% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.73%. Comparing base (a9e744b) to head (46a592f).

Files with missing lines Patch % Lines
include/GMGPolar/solver.h 80.00% 4 Missing ⚠️
include/GMGPolar/setup.h 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   95.79%   95.73%   -0.07%     
==========================================
  Files          79       79              
  Lines        8663     8623      -40     
==========================================
- Hits         8299     8255      -44     
- Misses        364      368       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz

julianlitz commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

image

Should be (385 x 512) -> (7 x 8)

@EmilyBourne EmilyBourne merged commit 4503ceb into main Jun 15, 2026
7 of 9 checks passed
@EmilyBourne EmilyBourne deleted the ebourne_gradual_gpu_port_part_4 branch June 15, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants