Skip to content

Minor PCG improvement: Avoid vector copy #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmilyBourne merged 3 commits into from
Jun 15, 2026
Merged

Minor PCG improvement: Avoid vector copy #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22289d6
Update gmgpolar.h
julianlitz Jun 13, 2026
18d3444
Update solver.h
julianlitz Jun 13, 2026
faa7f1c
Merge branch 'main' into litz_avoid_self_copy_pcg_fmg
EmilyBourne Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/GMGPolar/gmgpolar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class GMGPolar : public IGMGPolar
void updateResidualNorms(Level<DomainGeometry, DensityProfileCoefficients>& level, int iteration,
double& initial_residual_norm, double& current_residual_norm,
double& current_relative_residual_norm);
void initRhsHierarchy(Vector<double> rhs);
void initRhsHierarchy();
void applyMultigridIterations(Level<DomainGeometry, DensityProfileCoefficients>& level, MultigridCycleType cycle,
int iterations);
void applyExtrapolatedMultigridIterations(Level<DomainGeometry, DensityProfileCoefficients>& level,
Expand Down
7 changes: 3 additions & 4 deletions include/GMGPolar/solver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ void GMGPolar<DomainGeometry, DensityProfileCoefficients>::solvePCG(double& init

// z = M^{-1} * r (preconditioned residual)
if (PCG_FMG_) {
initRhsHierarchy(level.rhs());
initRhsHierarchy();
fullMultigridApproximation(PCG_FMG_cycle_, PCG_FMG_iterations_);
}
else {
Expand Down Expand Up @@ -392,7 +392,7 @@ void GMGPolar<DomainGeometry, DensityProfileCoefficients>::solvePCG(double& init

// z = M^{-1} * r (preconditioned residual)
if (PCG_FMG_) {
initRhsHierarchy(level.rhs());
initRhsHierarchy();
fullMultigridApproximation(PCG_FMG_cycle_, PCG_FMG_iterations_);
}
else {
Expand Down Expand Up @@ -577,9 +577,8 @@ void GMGPolar<DomainGeometry, DensityProfileCoefficients>::applyExtrapolation(in
// =============================================================================

template <concepts::DomainGeometry DomainGeometry, concepts::DensityProfileCoefficients DensityProfileCoefficients>
void GMGPolar<DomainGeometry, DensityProfileCoefficients>::initRhsHierarchy(Vector<double> rhs)
void GMGPolar<DomainGeometry, DensityProfileCoefficients>::initRhsHierarchy()
{
Kokkos::deep_copy(levels_[0].rhs(), rhs);
Comment thread
EmilyBourne marked this conversation as resolved.
for (int level_depth = 0; level_depth < number_of_levels_ - 1; ++level_depth) {
Level<DomainGeometry, DensityProfileCoefficients>& current_level = levels_[level_depth];
Level<DomainGeometry, DensityProfileCoefficients>& next_level = levels_[level_depth + 1];
Expand Down
Loading