Fix gosec security issues#942
Open
jfantinhardesty wants to merge 3 commits into
Open
Conversation
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker,
brayan-trejo and
foodprocessor
as code owners
foodprocessor
requested changes
Jul 1, 2026
foodprocessor
left a comment
foodprocessor
left a comment
Contributor
There was a problem hiding this comment.
I don't think we should check for overflow in cases where it will never happen. To fix the vulnerability, we can and should normalize incoming values to make overflow impossible. I'm grateful to gosec for highlighting the issue, but I don't think the gosec integer overflow checker is mature enough to be included in our CI.
So, I think we should add G115 to the excludes list, and this PR should pivot to addressing the problem in the best way without affecting readability (normalize incoming values and change variable types to remove the need for conversions, where possible).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Add gosec as a linter which finds go security issues and fixed identified issues.
Checklist
Related Issues