Skip to content

feat: give native HTTP value types ruby value semantics#139

Open
arishgithub wants to merge 2 commits into
SearchApi:mainfrom
arishgithub:native-http-value-types-ruby-value-semantics
Open

feat: give native HTTP value types ruby value semantics#139
arishgithub wants to merge 2 commits into
SearchApi:mainfrom
arishgithub:native-http-value-types-ruby-value-semantics

Conversation

@arishgithub

Copy link
Copy Markdown

Closes: #126

@arishgithub

Copy link
Copy Markdown
Author

Hello @ZilvinasKucinskas @0x676e67, please review

@0x676e67

Copy link
Copy Markdown
Collaborator

@arishgithub Thanks for the contribution. I think you also need to add the relevant Ruby API declarations to the Ruby files under lib/**. We’ll merge this PR a bit later because the merge queue is quite long.

@arishgithub

Copy link
Copy Markdown
Author

@0x676e67 , I have added the relevant ruby definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give native HTTP value types Ruby value semantics

2 participants