Update dependency rubocop-rspec to v3.10.2#2712
Merged
Merged
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rubocop-rspec 3.10.2 adds RSpec/Output, which flags the puts calls in finders_spec.rb. That file is documentation example code (skip: 'these are just examples, not actual tests') referenced by pinned line numbers across multiple gh-codeblock docs, so autocorrecting it would break those references. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Code Review by Qodo
1.
|
Excluding the whole file let future edits introduce unintended console output elsewhere in the file without RuboCop catching it. Wrap only the two examples with puts calls in rubocop:disable/enable, matching the pattern already used in safari_spec.rb, and update the affected gh-codeblock line ranges in the finders docs (en, ja, pt-br, zh-cn) since two lines were added. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Code review by qodo was updated up to the latest commit 45908cb |
diemol
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.7.0→3.10.2Release Notes
rubocop/rubocop-rspec (rubocop-rspec)
v3.10.2Compare Source
RSpec/SpecFilePathFormatwhenCustomTransformmaps a namespace to an empty string. ([@sakuro])RSpec/MatchWithSimpleRegexto ignore regular expressions with options. ([@bquorning])v3.10.1Compare Source
Strictoption toRSpec/SharedContextto flagshared_contextwhenever it contains examples, even alongside setup code. ([@Darhazer])NegatedMatcherconfiguration optionRSpec/ExpectChange. ([@Darhazer])RSpec/MatchWithSimpleRegexto ignore regular expressions with interpolations. ([@bquorning])v3.10.0Compare Source
RSpec/MatchWithSimpleRegexto suggestincludematcher whenmatchis used with simple string literals without regex-specific features. ([@bquorning])RSpec/DiscardedMatcherto detect matchers in void context (e.g. missing.andbetween compound matchers). ([@ydakuka])itblocknodes. ([@Darhazer])RSpec/ScatteredLetnow preserves the order oflets during auto-correction. ([@Darhazer])RSpec/EmptyLineAfterFinalLetinsideshared_examples/include_examples/it_behaves_likeblocks. ([@Darhazer])RSpec/ContainExactlywhencontain_exactlyhas multiple splat arguments. ([@ydah])RSpec/SubjectDeclaration. ([@eugeneius])RSpec/SpecFilePathFormatwhen the expected class path only partially matches a path segment. ([@ydah])RSpec/ExpectActualwhen the matcher takes no arguments (e.g.expect("foo").to be_present,expect(1).to be). ([@cvx])v3.9.0Compare Source
RSpec/LeakyLocalVariablewhen variables are used only in example metadata (e.g., skip messages). ([@ydah])RSpec/ScatteredSetupwhen the hook is defined inside a class method. ([@d4rky-pl])RSpec/DescribedClassinside dynamically evaluated blocks (class_eval,module_eval,instance_eval,class_exec,module_exec,instance_exec). ([@sucicfilip])RSpec/Output. ([@kevinrobell-st])v3.8.0Compare Source
RSpec/LeakyLocalVariable. ([@lovro-bikic])RSpec/LetSetupwhenlet!used in outer scope. ([@ydah])RSpec/ReceiveNevercop whenallow(...).to receive(...).never. ([@ydah])RSpec/VerifiedDoubles. ([@ushi-as])RSpec/RepeatedExamplecop. ([@ydah])RSpec/SpecFilePathFormatleverage ActiveSupport inflections when configured. ([@corsonknowles], [@bquorning])Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.