Skip to content

Add C# example for unhandledPromptBehavior to translated docs#2729

Merged
diemol merged 2 commits into
trunkfrom
fix-csharp-unhandled-prompt-behavior-translated-docs
Jul 18, 2026
Merged

Add C# example for unhandledPromptBehavior to translated docs#2729
diemol merged 2 commits into
trunkfrom
fix-csharp-unhandled-prompt-behavior-translated-docs

Conversation

@diemol

@diemol diemol commented Jul 18, 2026

Copy link
Copy Markdown
Member

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Applies the CSharp unhandledPromptBehavior example from #2724 to the ja, pt-br, and zh-cn translations of options.md, which were missed in that PR.

Motivation and Context

#2724 replaced the placeholder badge in the CSharp tab of options.en.md with a real gh-codeblock reference, but the translated versions of that page still show the placeholder badge for the same section.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR #2724 wired the CSharp tab's unhandledPromptBehavior example into
options.en.md but missed the ja/pt-br/zh-cn translations, which still
showed the placeholder badge. Apply the same gh-codeblock reference
there.
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add C# unhandledPromptBehavior codeblock to translated options docs

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Replace the C# placeholder badge with a real gh-codeblock include in translated options.md
 pages.
• Align ja/pt-br/zh-cn translations with the existing English unhandledPromptBehavior example
 reference.
• Ensure C# tab renders the same .NET snippet across all languages.
Diagram

graph TD
  JA["options.ja.md"] --> SC["gh-codeblock include"] --> CS["OptionsTest.cs (L59-60)"]
  PT["options.pt-br.md"] --> SC --> CS
  ZH["options.zh-cn.md"] --> SC --> CS
Loading
High-Level Assessment

This is the most consistent approach: use the same gh-codeblock reference used in the English page so translations stay in sync with the canonical .NET example. Alternatives (duplicating inline code or reintroducing a generic placeholder) would increase drift risk and maintenance burden.

Files changed (3) +3 / -3

Documentation (3) +3 / -3
options.ja.mdWire C# unhandledPromptBehavior tab to .NET example snippet +1/-1

Wire C# unhandledPromptBehavior tab to .NET example snippet

• Replaces the C# tab placeholder ('badge-code') with a 'gh-codeblock' reference to '/examples/dotnet/SeleniumDocs/Drivers/OptionsTest.cs#L59-L60' so the Japanese page renders the actual example.

website_and_docs/content/documentation/webdriver/drivers/options.ja.md

options.pt-br.mdReplace C# placeholder badge with 'gh-codeblock' include +1/-1

Replace C# placeholder badge with 'gh-codeblock' include

• Updates the pt-br translation to render the real C# example by referencing the same .NET snippet lines (59-60) used elsewhere.

website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md

options.zh-cn.mdAdd 'gh-codeblock' reference for C# prompt behavior example +1/-1

Add 'gh-codeblock' reference for C# prompt behavior example

• Swaps the C# tab placeholder for a 'gh-codeblock' include pointing at the shared .NET example snippet to ensure the zh-cn page shows real code.

website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md

@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for selenium-dev failed.

Name Link
🔨 Latest commit 8d577af
🔍 Latest deploy log https://app.netlify.com/projects/selenium-dev/deploys/6a5bf6fd0b39190008a3d80e

@qodo-code-review

qodo-code-review Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@diemol
diemol merged commit 4814f1d into trunk Jul 18, 2026
3 of 6 checks passed
@diemol
diemol deleted the fix-csharp-unhandled-prompt-behavior-translated-docs branch July 18, 2026 21:58
@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 8d577af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant