fix(skill): use FC temp OSS for skill code packages#18
Open
117503445 wants to merge 6 commits into
Open
Conversation
Signed-off-by: 117503445 <t117503445@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the ar skill create --code-dir workflow to upload skill code as a ZIP to Function Compute (FC) TempBucket OSS and create the skill as a CODE_PACKAGE tool, rather than sending an inline zipFile. It also adds FC 2016-style request signing and improves skill packaging behavior by injecting a placeholder main.py when missing.
Changes:
- Implement FC TempBucket token retrieval + OSS upload flow, and pass
ossBucketName/ossObjectName/language/commandincodeConfigurationfor skill creation. - Add FC 2016
Authorization: FC ...signing and helper utilities (_fc_authorization, endpoint/object-name helpers). - Add unit/integration tests and update both English/Chinese skill docs to reflect the new code-package behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/agentrun_cli/commands/skill_cmd.py | Switch skill create to FC TempBucket OSS code-package flow; add signing/token/upload helpers; inject placeholder main.py when needed. |
| tests/unit/test_skill_cmd.py | Add unit coverage for ZIP placeholder injection and FC TempBucket signing/token/upload helpers; update create tests for CODE_PACKAGE body. |
| tests/integration/test_skill_cmd.py | Update integration coverage to assert CODE_PACKAGE request body and mock the FC TempBucket upload. |
| pyproject.toml | Add oss2 dependency required for OSS upload. |
| docs/en/skill.md | Document FC TempBucket upload + CODE_PACKAGE tool creation and placeholder main.py injection behavior. |
| docs/zh/skill.md | Same documentation update as English version (bilingual parity). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 117503445 <t117503445@gmail.com>
Signed-off-by: 117503445 <t117503445@gmail.com>
Sodawyx
reviewed
Jul 3, 2026
Sodawyx
reviewed
Jul 3, 2026
Signed-off-by: 117503445 <t117503445@gmail.com>
Signed-off-by: 117503445 <t117503445@gmail.com>
Signed-off-by: 117503445 <t117503445@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ar skill create --code-dirto upload the skill ZIP to FC TempBucket OSS and create aSKILL/CODE_PACKAGEtool.tempBucketTokensigning withAuthorization: FC ...instead of POP/CommonRequest auth.codeConfiguration.ossBucketName/ossObjectName/language/commandand stop sending inlinezipFilefor normal create.main.pyinjection for skill directories that do not contain an entrypoint.Real verification
Ran a real 149 cn-hangzhou smoke test with the patched CLI:
Review notes
Ran three Paseo sub-agent reviews with non-Codex providers:
claude/opus: found missing-account-id error handling gap; fixed and added regression test.claude/qwen3.7-max: suggested normalizing Date header lookup; fixed.claude/glm-5.2: suggested FC signature golden test; added.Tests
Result:
584 passed, total coverage95.27%.