-
Notifications
You must be signed in to change notification settings - Fork 1
[Swift] Add preload state observability #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a30598e
[Swift] Add preload state observability
markmur 7381e48
[Swift] Address preload observability review feedback
markmur 81a6587
Harden preload cache lifecycle and observability
markmur 365c328
Swift API dump
markmur d9587b4
Expire stale ready for hasEntry(key:)
markmur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
platforms/swift/Sources/ShopifyCheckoutKit/PreloadState.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import Combine | ||
| import Foundation | ||
|
|
||
| /// Observable lifecycle state of a preloaded checkout. | ||
| public enum PreloadState: Equatable { | ||
| case idle | ||
| case loading | ||
| case ready | ||
| case expired | ||
| case failed(reason: FailureReason) | ||
|
|
||
| public enum FailureReason: Equatable { | ||
| case httpError(statusCode: Int) | ||
| case navigationFailed | ||
| case keepAliveLost | ||
| } | ||
| } | ||
|
|
||
| /// Returned by `preload(checkout:)` to expose the current preload state. | ||
| /// | ||
| /// Retain the returned instance for as long as you want to observe state | ||
| /// changes; the cache holds it weakly. | ||
| @MainActor | ||
| public final class CheckoutPreload: ObservableObject { | ||
| /// The latest observed preload state. | ||
| @Published public private(set) var state: PreloadState | ||
|
|
||
| init(cache: PreloadCache) { | ||
| state = cache.state | ||
| cache.setObserver(self) | ||
| } | ||
|
|
||
| /// Called immediately with the current state and whenever it changes. | ||
| public var onStateChange: ((PreloadState) -> Void)? { | ||
| didSet { | ||
| onStateChange?(state) | ||
| } | ||
| } | ||
|
|
||
| func receive(_ state: PreloadState) { | ||
| self.state = state | ||
| onStateChange?(state) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.