[Refactor] Simplify tree-kill callback handling and remove redundant checks#8175
[Refactor] Simplify tree-kill callback handling and remove redundant checks#8175gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The internal helper functions
adaptedTreeKillandkillAllinpackages/cli-kit/src/public/node/tree-kill.tshad redundant checks to verify whethercallbackwas defined before calling it. However, thecallbackparameter is non-optional in both function signatures andtreeKillalways supplies a callback (defaulting to a log fallback if none is provided). Removing these redundant checks makes the file cleaner, simpler, and easier to maintain.WHAT is this pull request doing?
if (callback)checks in bothadaptedTreeKillandkillAll.eslint-disabledirective to satisfy custom ESLint rules regarding catch blocks without rethrows.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 11173730342096362835 started by @gonzaloriestra