Add test coverage for interface! rejecting classes#33
Open
mliem2k wants to merge 1 commit into
Open
Conversation
interface! already guards against being called on a Class (raising TypeError), which also covers the class << self case since a module's singleton class is itself a Class. Add specs to lock in this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interface!already raisesTypeErrorwhen called on aClass:This also already covers the
class << selfcase from the issue, since a module's singleton class is itself an instance ofClass:This existing guard (in
TypeToolkit.make_interface!) wasn't covered by any spec, so it was easy to lose track of. This PR adds specs for both raising cases, plus a sanity check thatinterface!still works normally on a plain module.Fixes #4
Test plan
bundle exec rake test— 92 runs, 0 failuresbundle exec rake rubocop— no offensesbundle exec rake typecheck— no errors