Skip to content

fix: green πŸ”Ž Check β€” repoint moved fleet script paths + wire lockstep:emit-mirror-globs#1437

Open
John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/check-green-script-paths
Open

fix: green πŸ”Ž Check β€” repoint moved fleet script paths + wire lockstep:emit-mirror-globs#1437
John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/check-green-script-paths

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

What

main's πŸ”Ž Check (pnpm run check --all) is red, blocking every PR. Two independent fleet scripts/repo-migration cascade breakages:

  1. check-script-paths-resolve β€” packages/cli/package.json still pointed check and update at ../../scripts/check.mts / ../../scripts/update.mts. The scripts/repo migration moved both into scripts/fleet/, so those paths no longer resolve.
  2. check-pnpm-run-citations-resolve β€” the cascaded updating-lockstep skill docs cite pnpm run lockstep:emit-mirror-globs, but the root package.json never got the matching alias. The backing script (scripts/fleet/lockstep-emit-mirror-globs.mts) and its sibling alias (lockstep:emit-schema) are both present β€” only the wiring was missing.

Fix

  • packages/cli/package.json: check β†’ ../../scripts/fleet/check.mts
  • packages/cli/package.json: update β†’ ../../scripts/fleet/update.mts
  • package.json: add lockstep:emit-mirror-globs β†’ node scripts/fleet/lockstep-emit-mirror-globs.mts (points at the existing shim; mirrors the lockstep:emit-schema entry byte-for-byte)

Why this is a repo-local fix (not a wheelhouse change)

  • The cli scripts are plain package.json entries here β€” no scripts/repo/sync-scaffolding/manifest.mts synthesizer exists in this repo, so editing package.json directly is the source of truth.
  • The lockstep:emit-mirror-globs script file already exists and documents this exact invocation; socket-cli was simply missing the alias (a cascade gap), so adding it is wiring an existing script, not inventing one. The skill doc citation is correct and needs no edit.

Verification (local, Node 24)

βœ” [check-script-paths-resolve] every package.json script path resolves.
βœ” [check-pnpm-run-citations-resolve] every `pnpm run` citation in skill/command docs resolves.

Also re-ran the sibling path-hygiene checks (all green): paths-are-canonical, doc-references-resolve, release-publish-scripts-are-conventionally-named, lockstep-mirror-markers-are-declared, root-scripts-are-segregated, entry-scripts-are-fail-soft.

Do not merge β€” a maintainer merges via --admin once a ruleset bypass is in place.


Note

Low Risk
Only package.json script path and alias wiring; no runtime, auth, or business logic changes.

Overview
Restores green pnpm run check --all by fixing stale package.json wiring after fleet scripts moved under scripts/fleet/.

In packages/cli/package.json, the check and update scripts now invoke ../../scripts/fleet/check.mts and ../../scripts/fleet/update.mts instead of the old scripts/ paths, so check-script-paths-resolve passes again.

At the repo root, lockstep:emit-mirror-globs is added as a pnpm alias to the existing scripts/fleet/lockstep-emit-mirror-globs.mts shim (same pattern as lockstep:emit-schema), so skill docs that cite pnpm run lockstep:emit-mirror-globs resolve under check-pnpm-run-citations-resolve.

Reviewed by Cursor Bugbot for commit 7478fe1. Configure here.

…lobs

The scripts/repo migration moved check.mts and update.mts into
scripts/fleet/, but packages/cli/package.json still pointed its
"check" and "update" scripts at the old ../../scripts/*.mts paths,
failing check-script-paths-resolve.

The lockstep-emit-mirror-globs.mts script cascaded in (and its sibling
lockstep:emit-schema is wired), but the root package.json never got the
matching lockstep:emit-mirror-globs alias, so the updating-lockstep skill
docs cited a pnpm script that did not resolve, failing
check-pnpm-run-citations-resolve.

- packages/cli/package.json: check -> ../../scripts/fleet/check.mts
- packages/cli/package.json: update -> ../../scripts/fleet/update.mts
- package.json: add lockstep:emit-mirror-globs pointing at the existing
  scripts/fleet/lockstep-emit-mirror-globs.mts shim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant