chore(QTDI-2894): S6204 Stream.toList()#1228
Open
undx wants to merge 13 commits into
Open
Conversation
(cherry picked from commit c877724)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Java stream terminal operations across the codebase, primarily replacing collect(Collectors.toList()) / collect(toList()) with Stream.toList() (per Sonar rule S6204), and updates a few generated documentation artifacts accordingly.
Changes:
- Replace many
Collectors.toList()usages withStream.toList()and remove now-unusedtoListimports. - Regenerate/update documentation partials that embed generated content.
- Apply the same migration in multiple test suites and tooling modules.
Reviewed changes
Copilot reviewed 152 out of 152 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vault-client/src/main/java/org/talend/sdk/components/vault/client/VaultClient.java | Replace Collectors.toList() with Stream.toList() in vault decryption flow. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/WebsiteBuilderMojo.java | Replace Collectors.toList() with Stream.toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ScanDescriptorMojo.java | Replace collect(toList()) with toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/IconReporterMojo.java | Replace collect(toList()) with toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/DependencyConflictsReporterMojo.java | Replace collect(toList()) with toList() in dependency conflict reporting. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentMetadataMojo.java | Replace collect(toList()) with toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentDependenciesBase.java | Replace collect(toList()) with toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ClasspathMojoBase.java | Replace collect(toList()) with toList() and remove static import. |
| talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/AsciidocMojo.java | Replace collect(toList()) with toList() and remove static import. |
| singer-parent/component-kitap/src/test/java/org/talend/sdk/component/singer/kitap/KitapTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/Kitap.java | Replace collect(toList()) with toList() and remove static import. |
| sample-parent/sample/src/main/java/org/talend/sdk/component/sample/other/ComplexComponent.java | Replace collect(toList()) with toList() and remove static import. |
| sample-parent/sample-features/checkpoint-runner/src/main/java/org/talend/sdk/component/sample/feature/checkpoint/IncrementalSequenceInput.java | Replace collect(toList()) with toList() in sample feature input. |
| sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/ActionsServices.java | Replace Collectors.toList() with toList() and remove import. |
| remote-engine-customizer/src/main/java/org/talend/sdk/component/remoteengine/customizer/task/RemoteEngineCustomizer.java | Replace collect(toList()) with toList() and remove static import. |
| remote-engine-customizer/src/main/java/org/talend/sdk/component/remoteengine/customizer/lang/IO.java | Replace collect(toList()) with toList() and remove static import. |
| documentation/src/main/java/org/talend/runtime/documentation/SearchIndexation.java | Replace collect(toList()) with toList() and remove static import. |
| documentation/src/main/java/org/talend/runtime/documentation/Github.java | Replace collect(toList()) with toList() in contributor loading. |
| documentation/src/main/java/org/talend/runtime/documentation/Generator.java | Replace collect(toList()) with toList() in Jira/changelog generation. |
| documentation/src/main/java/org/talend/runtime/documentation/component/source/MockTableMapper.java | Replace collect(toList()) with toList() and remove static import. |
| documentation/src/main/java/org/talend/runtime/documentation/component/service/MockTableService.java | Replace collect(toList()) with toList() and remove static import. |
| documentation/src/main/antora/modules/ROOT/pages/_partials/generated_rest-resources.adoc | Update generated embedded Swagger UI payload. |
| documentation/src/main/antora/modules/ROOT/pages/_partials/generated_contributors.adoc | Update generated contributor list/metadata. |
| container/nested-maven-repository/src/main/java/org/talend/sdk/component/container/maven/shade/ArtifactTransformer.java | Replace collect(toList()) with toList() when building filters. |
| container/container-core/src/test/java/org/talend/sdk/component/dependencies/maven/MvnDependencyListLocalRepositoryResolverTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| container/container-core/src/test/java/org/talend/sdk/component/ContainerTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| container/container-core/src/test/java/org/talend/sdk/component/ContainerManagerTest.java | Replace Collectors.toList() with toList() and remove import. |
| container/container-core/src/test/java/org/talend/sdk/component/classloader/ConfigurableClassLoaderTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| container/container-core/src/main/java/org/talend/sdk/component/container/ContainerManager.java | Replace collect(toList()) with toList() in listener handling. |
| container/container-core/src/main/java/org/talend/sdk/component/container/Container.java | Replace collect(toList()) with toList() for classpath file materialization. |
| container/container-core/src/main/java/org/talend/sdk/component/classloader/ConfigurableClassLoader.java | Replace collect(toList()) with toList() in resource aggregation. |
| component-tools/src/test/java/org/talend/sdk/component/tools/validator/ExceptionValidatorTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java | Replace collect(Collectors.toList()) with toList() in tests. |
| component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools/src/test/java/org/talend/sdk/component/tools/CarBundlerTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/validator/InternationalizationValidator.java | Replace multiple collect(toList()) with toList() and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/validator/HttpValidator.java | Replace Collectors.toList() with toList() and remove import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/validator/FixedSchemaValidator.java | Replace Collectors.toList() with toList() and remove import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/validator/DataStoreValidator.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/validator/DatasetValidator.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/StudioInstaller.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/DocBaseGenerator.java | Replace collect(toList()) with toList() and remove unused import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/DitaDocumentationGenerator.java | Replace collect(Collectors.toList()) with toList() and remove import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools/src/main/java/org/talend/sdk/component/tools/AsciidoctorExecutor.java | Replace collect(toList()) with toList() for file line collection. |
| component-tools-webapp/src/main/java/org/talend/sdk/component/tools/webapp/standalone/generator/StaticUiSpecGenerator.java | Replace collect(toList()) with toList() and remove static import. |
| component-tools-webapp/src/main/java/org/talend/sdk/component/tools/webapp/standalone/generator/StaticResourceGenerator.java | Replace multiple collect(toList()) with toList() in route generation. |
| component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java | Replace collect(toList()) with toList() in tests. |
| component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/record/DiRecordVisitorTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java | Replace collect(toList()) with toList() in Beam test setup. |
| component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java | Replace collect(toList()) with toList() and remove static import. |
| component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/beam/DelegatingUnBoundedSource.java | Replace collect(toList()) with toList() and remove static import. |
| component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/beam/DelegatingBoundedSource.java | Replace collect(toList()) with toList() and remove static import. |
| component-starter-server/src/test/java/org/talend/sdk/component/starter/server/service/facet/component/ComponentGeneratorConfigurationTest.java | Replace collect(toList()) with toList() in tests. |
| component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/source/MockTableMapper.java | Replace collect(toList()) with toList() and remove static import. |
| component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/service/MockTableService.java | Replace collect(toList()) with toList() in test service. |
| component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/openapi/OpenAPIGenerator.java | Replace nested collect(toList()) with toList() in OpenAPI parsing. |
| component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/facet/component/ComponentGenerator.java | Replace collect(toList()) with toList() when adding generated files. |
| component-starter-server/src/main/java/org/talend/sdk/component/starter/server/front/RRDEndpoint.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/tomcat/GenerateCertificateAndActivateHttpsTest.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/custom/CustomService.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/service/PropertiesServiceTest.java | Replace collect(toList()) with toList() in tests. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/VirtualDependenciesService.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/PropertyValidationService.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/ExtensionComponentMetadataManager.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/ComponentManagerService.java | Replace collect(toList()) with toList() in post-deploy aggregation. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/ActionsService.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/security/SecurityUtils.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/DocumentationResourceImpl.java | Replace collect(toList()) with toList() when reading docs cache. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ConfigurationTypeResourceImpl.java | Replace collect(toList()) with toList() and remove static import. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java | Replace multiple collect(toList()) with toList() in REST payload building. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/BulkReadResourceImpl.java | Replace collect(toList()) with toList() in bulk execution. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ActionResourceImpl.java | Replace collect(toList()) with toList() in action listing and details. |
| component-runtime-testing/component-runtime-testing-spark/src/main/java/org/talend/sdk/component/runtime/testing/spark/internal/BaseSpark.java | Replace collect(toList()) with toList() in Spark runner plumbing. |
| component-runtime-testing/component-runtime-junit/src/test/java/org/talend/sdk/component/junit5/ComponentExtensionTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| component-runtime-testing/component-runtime-junit/src/test/java/org/talend/sdk/component/junit/SimpleComponentRuleTest.java | Replace collect(toList()) with toList() in tests and remove static import. |
| component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/maven/MavenDecrypter.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit/environment/BaseEnvironmentProvider.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit/BaseComponentsHandler.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/ProducerFinderEnvironmentTest.java | Replace collect(toList()) with toList() in Beam tests. |
| component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/ProcessorTest.java | Replace collect(toList()) with toList() in assertions. |
| component-runtime-testing/component-runtime-beam-junit/src/main/java/org/talend/sdk/component/junit/beam/Data.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/test/java/org/talend/test/CheckpointInput.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ReflectionServiceTest.java | Replace collect(toList()) with toList() in test expectations. |
| component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/interceptor/InterceptorTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/chain/JobTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/ResolverImpl.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/RecordPointerFactoryImpl.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/LocalCacheService.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/RequestParser.java | Replace collection.collect(toList()) with collection.toList() in CSV formatting. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/HttpClientFactoryImpl.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/visibility/VisibilityService.java | Replace collect(toList()) with toList() in JSON array mapping. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java | Replace collect(toList()) with toList() in parameter factory mapping. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ParameterModelService.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/parameterenricher/UiParameterEnricher.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ComponentMetadataService.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/interceptor/InterceptorHandlerFacade.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/configuration/ConfigurationMapper.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java | Replace multiple collect(toList()) with toList() in service loading and setup. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/chain/internal/JobImpl.java | Replace collect(toList()) with toList() for graph traversal lists. |
| component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/asm/ProxyGenerator.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/SchemaImplTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordConvertersTest.java | Replace collect(toList()) with toList() in assertions. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java | Replace Collectors.toList() with toList() in tests. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/OrderedMapTest.java | Replace Collectors.toList() with toList() in tests. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/output/ProcessorImplTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/input/PartitionMapperImplTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/visitor/ModelVisitor.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/serialization/EnhancedObjectInputStream.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/SchemaImpl.java | Replace internal collection with toList() for entries ordering. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/RecordImpl.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/json/RecordJsonGenerator.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/output/ProcessorImpl.java | Replace collect(toList()) with toList() in lifecycle method discovery. |
| component-runtime-design-extension/src/test/java/org/talend/sdk/component/design/extension/repository/RepositoryModelBuilderTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-design-extension/src/main/java/org/talend/sdk/component/design/extension/repository/RepositoryModelBuilder.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-design-extension/src/main/java/org/talend/sdk/component/design/extension/flows/ProcessorFlowsFactory.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/RecordBranchUnwrapperTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/RecordBranchMapperTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/RecordBranchFilterTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/avro/SchemalessJsonToIndexedRecordTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/avro/JsonToIndexedRecordTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/avro/IndexedRecordToJsonTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/transform/AutoKVWrapperTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/TalendIOTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaCacheTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecordTest.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/NativeWrappedIOTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/coder/JsonpJsonObjectCoderTest.java | Replace collect(toList()) with toList() in tests. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/transform/avro/SchemalessJsonToIndexedRecord.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/SchemaIdGenerator.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaConverter.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaBuilder.java | Replace Collectors.toList() with toList() and remove import. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchema.java | Replace collect(toList()) with toList() in schema entry extraction. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java | Replace collect(toList()) with toList() in mapping logic. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/customizer/Indices.java | Replace collect(toList()) with toList() and remove static import. |
| component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/chain/impl/BeamExecutor.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-uispec-mapper/src/main/java/org/talend/sdk/component/form/uispec/mapper/impl/UiSpecMapperImpl.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-model/src/main/java/org/talend/sdk/component/form/model/uischema/UiSchema.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/test/java/org/talend/sdk/component/form/internal/validation/ValidationServiceTest.java | Replace collect(toList()) with toList() in tests. |
| component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java | Replace multiple collect(toList()) with toList() and remove imports. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/validation/spi/ext/TypeValidation.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/MultiSelectWidgetConverter.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/GridLayoutWidgetConverter.java | Replace collect(toList()) with toList() in tab list computation. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/DataListWidgetConverter.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java | Replace multiple collect(toList()) with toList() in dynamic value conversion. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/UiSchemaConverter.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/schema/ArrayPropertyConverter.java | Replace collect(toList()) with toList() and remove static import. |
| component-form/component-form-core/src/main/java/org/talend/sdk/component/form/api/UiSpecService.java | Replace collect(toList()) with toList() and remove static import. |
| component-api/src/test/java/org/talend/sdk/component/api/record/OrderedMapTest.java | Replace Collectors.toList() with toList() in tests. |
| component-api/src/main/java/org/talend/sdk/component/api/record/Schema.java | Replace Collectors.toList() with toList() in API defaults and parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
|
Here we are replacing mutable List with immutable. Are we sure? |
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.14.0</version> | ||
| <configuration> |
Contributor
There was a problem hiding this comment.
it should not be inside this PR
Contributor
There was a problem hiding this comment.
or maybe it's just related to that: toList doesn't exist for pure JDK 1.8 -> so we can include that in this pr
| .orElse("An application generated by the Talend Component Kit Starter"), | ||
| "jar", group, ofNullable(model.getArtifact()).orElse("application"), | ||
| ofNullable(model.getVersion()).orElse("0.0.1-SNAPSHOT"), "1.8"), | ||
| ofNullable(model.getVersion()).orElse("0.0.1-SNAPSHOT"), "17"), |
ozhelezniak-talend
approved these changes
Jun 30, 2026
ozhelezniak-talend
left a comment
ozhelezniak-talend
left a comment
Contributor
There was a problem hiding this comment.
okay
with note that I didn't open each file locally to check if that replacement of mutable list to immutable is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-2894
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code