fix(QTDI-3124): [Refactoring] Merge sonar fixes by undx · Pull Request #1248 · Talend/component-runtime

undx · 2026-06-26T09:28:56Z

Requirements

This issue includes all the following refactoring issues rebased and merged on each others:

S6201 Pattern instanceof
S6204 Stream.toList()
S6126 Text blocks
S6208 Switch case merging
S1068 / S1481 Unused declarations
S1124 Modifier order
S2095 Resource leaks

Will be tested as a full non regression campaign test cycle.

Why this PR is needed?

Clear some sonar warnings

What does this PR adds (design/code thoughts)?

AI generated code

this PR has been written with the help of GitHub Copilot or another generative AI tool for checking risks and possible regressions.

Replace `instanceof` + manual cast patterns with Java 17 pattern matching for instanceof to reduce Sonar warnings (java:S6201). Both `(X) value` and `X.class.cast(value)` cast forms are handled. Excluded cases: - Conditions combined with `||` (pattern matching incompatible with alternation): AvroSchemaCache, SchemaConverter (Double||Float). - ParameterSetter#set: target variable declared outside the `if` block (would require restructuring). - Casts to a type different from the `instanceof` check (not S6201).

(cherry picked from commit c877724)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

- used intellij inspection as it is...

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

# Conflicts: # component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/studio/ParameterSetter.java

…' into ouf/QTDI-3124-sonar-fixes # Conflicts: # component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/xbean/converter/SchemaConverter.java

…o ouf/QTDI-3124-sonar-fixes # Conflicts: # component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java # component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/json/RecordJsonGenerator.java # component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordConvertersTest.java # component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java # component-runtime-testing/component-runtime-beam-junit/src/main/java/org/talend/sdk/component/junit/beam/Data.java

… into ouf/QTDI-3124-sonar-fixes

…g' into ouf/QTDI-3124-sonar-fixes # Conflicts: # component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/validation/spi/ext/BaseValidation.java # component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/util/DefaultValueInspector.java # singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/Kitap.java

…' into ouf/QTDI-3124-sonar-fixes # Conflicts: # component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java # component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java # component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBulkAutoChunkTest.java # component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java # component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java

…to ouf/QTDI-3124-sonar-fixes # Conflicts: # component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java

…to ouf/QTDI-3124-sonar-fixes # Conflicts: # component-tools/src/main/java/org/talend/sdk/component/tools/AsciidoctorExecutor.java

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

ozhelezniak-talend · 2026-06-30T05:44:46Z

Hello @undx
Was this changes done by Static analyzer tool or by AI?

sonar-rnd · 2026-07-01T08:01:47Z

Quality Gate failed

0.00% Coverage on New Code (is less than 80.00%)
138 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

undx and others added 30 commits May 21, 2026 17:56

chore(QTDI-2893): rename pattern match

e6240c6

chore(QTDI-2894): S6204 Stream.toList()

ffe2f53

(cherry picked from commit c877724)

chore(QTDI-2894): S6204 Stream.toList() - potential API break

17159c0

chore(QTDI-2894): S6204 Stream.toList() - restore partials

6d71def

chore(QTDI-2894): try-with-resources

3e5d2fa

chore(QTDI-2894): remove compiler level 1.8

9cd070b

chore(QTDI-2894): fix compiler level 17 tests

c96713e

chore(QTDI-2894): add safe S6204 not detected

01b1ba4

chore(QTDI-2894): add more S6204

573bcbb

chore(QTDI-2894): fix test for non regression

1a8b0cb

Merge branch 'master' into ouf/QTDI-2894_stream_tolist

d0f6301

chore(QTDI-2894): fix possible api break

9d62a6c

chore(QTDI-2894): fix possible api break -tests

8359900

chore(QTDI-2897): fix S1068

773745f

chore(QTDI-2897): fix S1481

21bd64c

chore(QTDI-2897): fix copilot comments

98acc3a

chore(QTDI-2897): fix missing stream

625c013

chore(QTDI-2897): fix revert refactoring going out of scope

28688df

Potential fix for pull request finding

e3d55e3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

0a37e2d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: replace no-op stream collect with entrySet forEach in migrate

33883a3

chore(QTDI-2895): S6126 Text blocks initial raw commit

e3aab06

- used intellij inspection as it is...

Potential fix for pull request finding

8c91e16

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix review comments: XML tag, grammar issues in validator and API docs

be97a2e

Potential fix for pull request finding

823c113

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix remaining review findings

1583231

chore(QTDI-2895): S6126 corrected some Text blocks

c246b7b

chore(QTDI-2895): S6126 fix EntryTest

05b0c2f

Potential fix for pull request finding

74e6c6d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

undx and others added 18 commits May 29, 2026 16:07

chore(QTDI-2898): S1124 Modifier order - fix tests

7f13466

chore(QTDI-2901): S2095 Resource leaks

d704efe

Merge branch 'master' into ouf/QTDI-2893_pattern_instanceof

ff76b94

Merge branch 'master' into ouf/QTDI-2898-Modifier-order

e1417ff

chore(QTDI-2893): S6201 changes after rebase

4a4ba72

chore(QTDI-2893): S6201 changes after code review

dee61f0

chore(QTDI-2893): reset to master

32956b8

chore(QTDI-2893): S6201 intellij processed

e051e5e

chore(QTDI-2893): S6201 manual processed

9ef6614

Merge remote-tracking branch 'origin/ouf/QTDI-2893_pattern_instanceof…

f8eae9f

…' into ouf/QTDI-3124-sonar-fixes # Conflicts: # component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/xbean/converter/SchemaConverter.java

Merge remote-tracking branch 'origin/ouf/QTDI-2895-sonar-text-blocks'…

7d157ee

… into ouf/QTDI-3124-sonar-fixes

Merge remote-tracking branch 'origin/ouf/QTDI-2898-Modifier-order' in…

adfd7f5

…to ouf/QTDI-3124-sonar-fixes # Conflicts: # component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java

Merge remote-tracking branch 'origin/out/QTDI-2901-Resource-leaks' in…

76744fc

…to ouf/QTDI-3124-sonar-fixes # Conflicts: # component-tools/src/main/java/org/talend/sdk/component/tools/AsciidoctorExecutor.java

fix(QTDI-3124): fix merge issues

a935837

undx requested a review from Copilot June 26, 2026 09:29

Copilot AI reviewed Jun 26, 2026

undx changed the title ~~Ouf/qtdi 3124 sonar fixes~~ fix(QTDI-3124): [Refactoring] Merge sonar fixes Jun 26, 2026

fix(QTDI-3124): fix merge issues

c64bfbc

undx requested a review from Copilot June 29, 2026 14:45

Copilot AI reviewed Jun 29, 2026

undx requested a review from ozhelezniak-talend June 29, 2026 14:45

undx added 2 commits June 29, 2026 18:40

fix(QTDI-3124): S6204 toList() remove the unmodiableList method

16db973

fix(QTDI-3124): S6204 remove tedious toList() changes

2f57780

fix(QTDI-3124): remove tedious unused var

da5c25b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(QTDI-3124): [Refactoring] Merge sonar fixes#1248

fix(QTDI-3124): [Refactoring] Merge sonar fixes#1248
undx wants to merge 60 commits into
masterfrom
ouf/QTDI-3124-sonar-fixes

undx commented Jun 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

ozhelezniak-talend commented Jun 30, 2026

Uh oh!

sonar-rnd Bot commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

undx commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements

Why this PR is needed?

What does this PR adds (design/code thoughts)?

AI generated code

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

ozhelezniak-talend commented Jun 30, 2026

Uh oh!

sonar-rnd Bot commented Jul 1, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

undx commented Jun 26, 2026 •

edited

Loading