Track generated route tree in scaffolds#464
Conversation
|
Worried about impact? Review this PR in Change Stack to explore blast radius before you approve or request changes. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthroughThis PR enables automatic route tree generation in newly scaffolded React and Solid file-router projects by running a ChangesRoute Tree Generation Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/create/tests/create-app.test.tsParsing error: "parserOptions.project" has been provided for packages/create/tests/framework-template.test.tsParsing error: "parserOptions.project" has been provided for Comment |
9f16272 to
adabbf0
Compare
What changed
src/routeTree.gen.tsto generated React and Solid app gitignores.generate-routesscripts,@tanstack/router-cli, andtsr.config.jsonto the file-router scaffolds.routeTree.gen.tsavailable.Why
routeTree.gen.tsis generated, but it is still source input for Router type checking. Ignoring it by default means a fresh checkout can failtscunless users run dev/build first. The scaffold should track the file and only hide it from editor/lint noise.Validation
pnpm --filter @tanstack/create buildpnpm --filter @tanstack/create exec tsc --noEmitpnpm --filter @tanstack/create testSummary by CodeRabbit
generate-routesnpm script for manual route regeneration in new projects