test(react-query/useQuery.promise): unskip 'cancelQueries' while suspending test by keeping 'queryFn' in-flight - #10910
Open
sukvvon wants to merge 29 commits into
Open
Conversation
…ending test by keeping 'queryFn' in-flight
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA previously skipped suspension and cancellation test is enabled. Its mocked query function now waits longer before resolving with constant data, preserving the in-flight promise while ChangesTest cancellation behavior under suspension
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 26df022
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Contributor
size-limit report 📦
|
…n cancel-while-suspending test
sukvvon
marked this pull request as draft
June 10, 2026 12:24
sukvvon
marked this pull request as ready for review
July 26, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Unskip
should stay pending when canceled with cancelQueries while suspending until refetched.The test was skipped because it had become flaky. With
vi.useFakeTimers({ shouldAdvanceTime: true }), awaitingtakeRender()advances the shared fake clock by ~35ms while waiting for the React commit. The originalsleep(10)queryFntherefore resolved beforecancelwas clicked, so the query reachedsuccessinstead of staying in-flight — the "cancel while suspending" scenario could never be exercised.sleepfrom10to50so the fetch outlasts thetakeRenderclock advance and is still in-flight whencancelQueriesruns.queryFnto thesleep(...).then(...)form and drop the unusedcountcounter (its return value is never asserted; the test verifies state and asetQueryDatavalue).sleepis intentionally longer than usual.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Note: This release contains no user-facing changes or new features.