26.1 facade connected textures#562
Open
Burkino wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Facaded blocks now work with connected textures, who could have guessed it's as simple as implementing
getAppearance(and some neighbor face hiding) (which also exists on 1.19.2 so it could probably easily be backported).Applying a Minecraft glass facade and placing a glass block next to it won't hide the facade's face which isn't the correct behavior. I guess non-solid block facades will just always be kinda weird
I changed FacadeTransparency to a boolean property, it only had 2 values and used everywhere as a boolean. Existing transparent facades will be weird until re-facaded
Also disabled Mekanism support because they're skipping 26.1, and some changes they've made requires updating other code