Skip to content

Load the Liberty in view_cells.tcl#4298

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:view_cells-with-liberty
Jun 19, 2026
Merged

Load the Liberty in view_cells.tcl#4298
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:view_cells-with-liberty

Conversation

@maliberty

Copy link
Copy Markdown
Member

Allows you to see the data in the inspector.

Allows you to see the data in the inspector.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Jun 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates flow/scripts/view_cells.tcl to source util.tcl and read_liberty.tcl. The review feedback correctly points out that sourcing read_liberty.tcl unconditionally can cause crashes if required environment variables like LIB_FILES or CORNERS are missing, and suggests guarding the import with a conditional check.

Comment thread flow/scripts/view_cells.tcl
@maliberty maliberty merged commit 764b452 into The-OpenROAD-Project:master Jun 19, 2026
8 checks passed
@maliberty maliberty deleted the view_cells-with-liberty branch June 19, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant