Skip to content

bugfix: Render ground-aligned particles without sorting #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephanmeesters wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

bugfix: Render ground-aligned particles without sorting #2838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45a97a7
perf: Render ground-aligned particles without sorting
stephanmeesters Jun 27, 2026
8ab6dd2
Clarify bugfix comment, add info comment for volumetric particles
stephanmeesters Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Core/Libraries/Source/WWVegas/WW3D2/pointgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,8 +926,14 @@ void PointGroupClass::Render(RenderInfoClass &rinfo)
DX8Wrapper::Set_Shader(Shader);
DX8Wrapper::Set_Texture(0,Texture);

// TheSuperHackers @bugfix stephanmeesters 30/06/2026
// Enable sorting if the primitives are translucent and alpha testing is not enabled.
const bool sort = (Shader.Get_Dst_Blend_Func() != ShaderClass::DSTBLEND_ZERO) && (Shader.Get_Alpha_Test() == ShaderClass::ALPHATEST_DISABLE) && (WW3D::Is_Sorting_Enabled());
// However, do not apply sorting to ground-aligned particles. This improves performance and resolves rendering

@xezon xezon Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: TheSuperHackers @bugfix stephanmeesters 30/06/2026 However, do not apply sorting to ground-aligned particles. This improves performance and resolves rendering ...

Otherwise it looks as if EA comment above is yours.

// artifacts caused by clipping between ground-aligned particles and billboard particles.
const bool sort = Billboard &&
Shader.Get_Dst_Blend_Func() != ShaderClass::DSTBLEND_ZERO &&
Shader.Get_Alpha_Test() == ShaderClass::ALPHATEST_DISABLE &&
WW3D::Is_Sorting_Enabled();

IndexBufferClass *indexbuffer;
int verticesperprimitive;/// lorenzen fixed
Expand Down Expand Up @@ -1835,7 +1841,9 @@ void PointGroupClass::RenderVolumeParticle(RenderInfoClass &rinfo, unsigned int
DX8Wrapper::Set_Shader(Shader);
DX8Wrapper::Set_Texture(0,Texture);

// TheSuperHackers @info stephanmeesters 30/06/2026
// Enable sorting if the primitives are translucent and alpha testing is not enabled.
// Volumetric particles that are ground-aligned must have sorting enabled.

@xezon xezon Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: // TheSuperHackers @info Volumetric particles that are ground-aligned must have sorting enabled.

const bool sort = (Shader.Get_Dst_Blend_Func() != ShaderClass::DSTBLEND_ZERO) && (Shader.Get_Alpha_Test() == ShaderClass::ALPHATEST_DISABLE) && (WW3D::Is_Sorting_Enabled());

IndexBufferClass *indexbuffer;
Expand Down
Loading