Skip to content

fix(gui): Pace whole-screen fade loop through the frame pacer #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobtista wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(gui): Pace whole-screen fade loop through the frame pacer #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e11d92f
fix(gui): Pace whole-screen fade loop through the frame pacer
bobtista Jun 30, 2026
6219f68
fix(gui): Replicate fade-loop frame pacer fix to Generals
bobtista Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Generals/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,9 @@ void GameLogic::tryStartNewGame( Bool loadingSaveGame )
{
TheDisplay->draw();
setFPMode();
Sleep(33);
// TheSuperHackers @fix bobtista 29/06/2026 Pace through the frame pacer so the fade caps the
// framerate and steps by real elapsed time, instead of a hardcoded frame-rate-dependent delay.
TheFramePacer->update();
}

}
Expand Down
4 changes: 3 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,7 +2247,9 @@ void GameLogic::tryStartNewGame( Bool loadingSaveGame )
{
TheDisplay->draw();
setFPMode();
Sleep(33);
// TheSuperHackers @fix bobtista 29/06/2026 Pace through the frame pacer so the fade caps the
// framerate and steps by real elapsed time, instead of a hardcoded frame-rate-dependent delay.
TheFramePacer->update();
}

}
Expand Down
Loading