Reject invalid Sec-WebSocket-Key values#119
Open
94xhn wants to merge 1 commit into
Open
Conversation
Reject keys that are not the 24-character padded Base64 form or do not decode to exactly 16 bytes before generating the accept response. Tested: CMake/Ninja build; handshake response regression harness
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RFC 6455 requires
Sec-WebSocket-Keyto be a Base64 value that decodes toexactly 16 bytes. Before this fix, malformed keys could still produce a
101 Switching Protocolsresponse.This revision rejects a key unless it has the required 24-character padded
form and the existing Base64 decoder produces exactly 16 bytes. The previous
variable-length SHA-1 change is removed, so the accepted key and GUID are
hashed using the existing
WS_KEYMS_LENlength.Verification
s3pPLMBiTxaQ9kYGzzhZRbK+xOo=.and 18-byte keys are rejected by the complete handshake-response path.
-Werror -pedantic.Checklist