Skip to content

Footswitch bugfixes#178

Open
sastraxi wants to merge 8 commits into
TreeFallSound:pistomp-v3from
sastraxi:feat/simple-footswitch-ui
Open

Footswitch bugfixes#178
sastraxi wants to merge 8 commits into
TreeFallSound:pistomp-v3from
sastraxi:feat/simple-footswitch-ui

Conversation

@sastraxi

@sastraxi sastraxi commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Reworks the LCD footswitch strip (on v3) so stays in sync with MOD-UI and behaves consistently whether it is bound to a bypass or to an arbitrary parameter.

What changed

  1. A footswitch bound to a parameter other than :bypass now derives its on/off state directly from the parameter value, without the bypass inversion. This means toggle parameters like a "Solo" switch light up exactly when MOD-UI says they are on, rather than silently staying constant.
  2. Plugin.set_param_value is introduced as the single path for updating a parameter's cached value and pushing that value to every control bound to it. Mod now routes both param_set and connect-dump updates through this helper, so bound footswitches (and future controls) stay in sync without duplicating the update logic.
  3. ShroudedPanel gives modal overlays a translucent dark backing that dims whatever is underneath, without requiring the underlying panel to redraw. It integrates with PanelStack so non-input panels can be shown without stealing focus.

sastraxi and others added 8 commits June 18, 2026 04:00
Erase the previously drawn keycap on single-widget refresh so a narrower
label no longer leaves ghost pixels from a wider one, giving a consistent
black backdrop. Track the keycap footprint slot-relative so the erase never
touches a neighbouring switch.

Make drives_display true for non-:bypass param bindings: only :bypass gets a
WS bypass-echo redraw, so footswitches bound to other params (e.g. mixer Solo)
must update their own LED/LCD on press.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@sastraxi sastraxi force-pushed the feat/simple-footswitch-ui branch from e73e18d to 572cb14 Compare June 18, 2026 15:48
@sastraxi sastraxi changed the title Footswitch rewrite (more vertical space, bugfixes) Footswitch bugfixes Jun 18, 2026
@sastraxi sastraxi requested a review from rreichenbach June 18, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant