Skip to content

Don't show tuner for v2 hardware #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rreichenbach merged 2 commits into from
Jun 21, 2026
Merged

Don't show tuner for v2 hardware #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee91c1
Don't show v2 tuner
sastraxi Jun 21, 2026
32530ff
Merge pull request #185 from sastraxi/fix/no-v2-tuner
rreichenbach Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modalapi/modhandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ def __init__(self, audiocard: Audiocard, homedir, data_dir="/home/pistomp/data")
self.ws_bridge.start()
logging.info("WebSocket bridge started")

# Tuner state
# Tuner state (may be disabled on slow hardware)
self.tuner_supported: bool = True
self._tuner_engine: TunerEngine | None = None
self._tuner_panel: TunerPanel | None = None
self._tuner_source_factory: TunerSourceFactory | None = None
Expand Down Expand Up @@ -1049,6 +1050,8 @@ def _tuner_factory(self, port: str) -> AudioSource:
return factory(port, name=f"pistomp-tuner-{port.split('_')[-1]}")

def toggle_tuner_enable(self, *argv) -> None:
if not self.tuner_supported:
return
if self._tuner_engine is None:
muted = bool(self.settings.get_setting(Token.TUNER_MUTE))
input_port = int(self.settings.get_setting(Token.TUNER_INPUT) or 1)
Expand Down
1 change: 1 addition & 0 deletions pistomp/handlerfactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def create(self, cfg, audiocard, cwd):
handler = Mod.Mod(audiocard, cwd)
elif (version >= 2.0) and (version < 3.0):
handler = Modhandler.Modhandler(audiocard, cwd)
handler.tuner_supported = False
elif (version >= 3.0) and (version < 4.0):
handler = Modhandler.Modhandler(audiocard, cwd)
else:
Expand Down
7 changes: 4 additions & 3 deletions pistomp/lcd320x240.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,9 +545,10 @@ def get_footswitch_pitch(self):
# System Menu
#
def draw_system_menu(self, event, widget):
items = [("System info", self.draw_system_info_dialog, None),
("Tuner", self._toggle_tuner_from_menu, None),
("System shutdown", self.handler.system_menu_shutdown, None),
items = [("System info", self.draw_system_info_dialog, None)]
if self.handler and self.handler.tuner_supported:
items.append(("Tuner", self._toggle_tuner_from_menu, None))
items += [("System shutdown", self.handler.system_menu_shutdown, None),
("System reboot", self.handler.system_menu_reboot, None),
("Restart sound engine", self.handler.system_menu_restart_sound, None),
("Bank Select >", self.draw_bank_menu, None),
Expand Down