test: cover checkout pre-flight persistence#1613
Conversation
Merge summary
Verification
|
📝 WalkthroughWalkthroughA new PHPUnit test method was added to Checkout_Test.php to verify that persist_current_step_to_session correctly filters out pre-flight, checkout_action, and _wpnonce fields from persisted session data while storing submitted email_address under signup['pre_selected']. ChangesCheckout test coverage
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Admin Merge Fallback (t2247)Branch protection blocked the plain Merge method: Original branch-protection errorRemediation: If this bypass was unintended, revert with aidevops.sh v3.32.4 plugin for OpenCode v1.17.13 with unknown spent 4m and 70,615 tokens on this as a headless worker. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/WP_Ultimo/Checkout/Checkout_Test.php`:
- Around line 632-640: The pre-flight test in Checkout_Test only asserts the
nested pre_selected email, so the top-level signup payload contract is not
pinned down. Update the test around the invoke($checkout) / get('signup') flow
to also assert the presence or absence of signup['email_address'] alongside
signup['pre_selected']['email_address'], using the existing $saved and $signup
assertions to make the expected write behavior explicit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9fd8037d-ea10-4a45-9f48-1aa202f51eab
📒 Files selected for processing (1)
tests/WP_Ultimo/Checkout/Checkout_Test.php
| $saved = $method->invoke($checkout); | ||
| $signup = $session->get('signup'); | ||
|
|
||
| $this->assertArrayNotHasKey('pre-flight', $saved); | ||
| $this->assertArrayNotHasKey('checkout_action', $saved); | ||
| $this->assertArrayNotHasKey('_wpnonce', $saved); | ||
| $this->assertSame('pre-flight@example.com', $saved['email_address']); | ||
| $this->assertSame('pre-flight@example.com', $signup['pre_selected']['email_address']); | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Map the test file and locate the relevant method.
ast-grep outline tests/WP_Ultimo/Checkout/Checkout_Test.php --view expanded
# Find the implementation that persists the current step to session.
rg -n "function persist_current_step_to_session|persist_current_step_to_session\(" tests/WP_Ultimo src lib includes wp-content -g '!vendor' -g '!node_modules' || trueRepository: Ultimate-Multisite/ultimate-multisite
Length of output: 17857
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Read the test method around the referenced lines.
sed -n '600,650p' tests/WP_Ultimo/Checkout/Checkout_Test.php
# Locate the implementation file and method body.
rg -n "function persist_current_step_to_session" .
# If the method is found, print a tight surrounding range.
# (The `awk` block handles the first matching file path from rg.)
path=$(rg -l "function persist_current_step_to_session" . | head -n 1)
if [ -n "${path:-}" ]; then
echo "--- IMPLEMENTATION: $path ---"
rg -n "persist_current_step_to_session|pre-flight|pre_selected|add_values\(" "$path"
line=$(rg -n "function persist_current_step_to_session" "$path" | head -n 1 | cut -d: -f1)
start=$((line - 20))
[ "$start" -lt 1 ] && start=1
end=$((line + 80))
sed -n "${start},${end}p" "$path"
fiRepository: Ultimate-Multisite/ultimate-multisite
Length of output: 4938
Assert the top-level signup write too. This test only checks signup['pre_selected']['email_address']; add an assertion for signup['email_address'] being present or absent so the pre-flight contract is pinned down.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/WP_Ultimo/Checkout/Checkout_Test.php` around lines 632 - 640, The
pre-flight test in Checkout_Test only asserts the nested pre_selected email, so
the top-level signup payload contract is not pinned down. Update the test around
the invoke($checkout) / get('signup') flow to also assert the presence or
absence of signup['email_address'] alongside
signup['pre_selected']['email_address'], using the existing $saved and $signup
assertions to make the expected write behavior explicit.
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
superdav42
added
the
review-feedback-scanned
1 participant
Summary
persist_current_step_to_session()pre-flight branch.signup.pre_selected.Testing
vendor/bin/phpcs tests/WP_Ultimo/Checkout/Checkout_Test.phpvendor/bin/phpunit --filter test_persist_current_step_to_session_handles_pre_flightResolves #1612
Summary by CodeRabbit