FIX: [UUM-145509] Simulator Plugin disabling input devices always. - #2457
Open
diverges wants to merge 4 commits into
Open
FIX: [UUM-145509] Simulator Plugin disabling input devices always.#2457diverges wants to merge 4 commits into
diverges wants to merge 4 commits into
Conversation
|
|
diverges
force-pushed
the
platform/workflows/fix-input-manager-device-simulator-plugin
branch
from
July 22, 2026 16:53
b3043c8 to
96cd571
Compare
Fix an issue where the Simulator Window would disable all input devices while open even though the window was not focused. This caused "Game View" to not properly receive input events. - Added a UI foldout with helpbox explaining this behavior. - Used created UIElement to capture the panel `InputSystemPlugin` connects to. - Enable/Disable devices based on SimulatorWindow focus state.
diverges
force-pushed
the
platform/workflows/fix-input-manager-device-simulator-plugin
branch
from
July 22, 2026 16:54
96cd571 to
c40f0ce
Compare
diverges
changed the title
diverges
marked this pull request as ready for review
July 27, 2026 22:39
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The focus-based change is close, but there is still a play-mode transition hole in the new state machine, and the accompanying test coverage does not build as checked in.
Reviewed commit 0047e168
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2457 +/- ##
===========================================
+ Coverage 78.95% 78.97% +0.02%
===========================================
Files 767 767
Lines 140780 140855 +75
===========================================
+ Hits 111147 111235 +88
+ Misses 29633 29620 -13 Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where the Simulator Window would disable all input devices while open even though the window was not focused. This caused "Game View" to not properly receive input events.
InputSystemPluginconnects to.Screen.Recording.2026-07-22.094016.mp4
Testing status & QA
Manual Testing.
Added automated tests for:
Overall Product Risks
Comments to reviewers
Device simulator related fixes.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.