Skip to content

chore: remove setting GhostField value work around - #4108

Merged
NoelStephensUnity merged 2 commits into
develop-3.x.xfrom
chore/update-changes-unified-trunk-ghostfield-apply-on-instantiate
Jul 28, 2026
Merged

chore: remove setting GhostField value work around#4108
NoelStephensUnity merged 2 commits into
develop-3.x.xfrom
chore/update-changes-unified-trunk-ghostfield-apply-on-instantiate

Conversation

@NoelStephensUnity

Copy link
Copy Markdown
Member

Purpose of this PR

Removing the work around method as setting GhostField.Value after instantiating works now.

Jira ticket

NA

Changelog

NA

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done
    • Used NGO Examples unified branch.

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

N/A

Backports

N/A

Removing the work around method as setting GhostField<T>.Value after instantiating works now.
@NoelStephensUnity
NoelStephensUnity requested a review from a team as a code owner July 28, 2026 02:26
@NoelStephensUnity
NoelStephensUnity enabled auto-merge (squash) July 28, 2026 02:26
Adjusting for suggested change in execution order.
@codecov-github-com

codecov-github-com Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-3.x.x    #4108      +/-   ##
=================================================
+ Coverage          70.44%   70.51%   +0.07%     
=================================================
  Files                146      146              
  Lines              23275    23276       +1     
=================================================
+ Hits               16396    16413      +17     
+ Misses              6879     6863      -16     
Flag Coverage Δ
NGOv2_ubuntu_6000.3 70.51% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs 66.52% <ø> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 70.51% <100.00%> (+0.07%) ⬆️

ℹ️ Need help interpreting these results?

@NoelStephensUnity
NoelStephensUnity merged commit 49e149e into develop-3.x.x Jul 28, 2026
26 checks passed
@NoelStephensUnity
NoelStephensUnity deleted the chore/update-changes-unified-trunk-ghostfield-apply-on-instantiate branch July 28, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants