fix: use System.Enum APIs in ToonEnumUtility to ensure ordering#836
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates ToonEnumUtility to build inspector labels and option values using System.Enum APIs rather than enumerating members via reflection, aiming to better align popup values with actual enum constants.
Changes:
ToInspectorNamesAsGUIContent: switched toEnum.GetNamesand looks upInspectorNameAttributeper enum field.ToIndices: switched toEnum.GetValuesto return the actual enum numeric values instead of sequential indices.- Removed an unused
usingdirective.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sindharta-tanuwijaya
changed the title
sindharta-tanuwijaya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.